From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] arm : at91sam9x5 : enable serial flash boot
Date: Thu, 16 Aug 2012 09:36:23 +0200 [thread overview]
Message-ID: <502CA2F7.7080302@gmail.com> (raw)
In-Reply-To: <1345092267-16077-3-git-send-email-voice.shen@atmel.com>
Dear Bo Shen,
On 16.08.2012 06:44, Bo Shen wrote:
> enable at91sam9x5 boot from serial flash
>
> Use at91sam9x5_dataflash to configure the u-boot
>
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
> ---
> arch/arm/cpu/arm926ejs/at91/at91sam9x5_devices.c | 4 ++--
> boards.cfg | 1 +
> include/configs/at91sam9x5ek.h | 18 ++++++++++++++----
> 3 files changed, 17 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/cpu/arm926ejs/at91/at91sam9x5_devices.c b/arch/arm/cpu/arm926ejs/at91/at91sam9x5_devices.c
> index 7558ca2..6d77219 100644
> --- a/arch/arm/cpu/arm926ejs/at91/at91sam9x5_devices.c
> +++ b/arch/arm/cpu/arm926ejs/at91/at91sam9x5_devices.c
> @@ -121,7 +121,7 @@ void at91_serial2_hw_init(void)
> #ifdef CONFIG_ATMEL_SPI
> void at91_spi0_hw_init(unsigned long cs_mask)
> {
> - at91_pmc_t *pmc = (at91_pmc_t *) ATMEL_PMC_BASE;
> + at91_pmc_t *pmc = (at91_pmc_t *) ATMEL_BASE_PMC;
>
> at91_set_a_periph(AT91_PIO_PORTA, 11, 0); /* SPI0_MISO */
> at91_set_a_periph(AT91_PIO_PORTA, 12, 0); /* SPI0_MOSI */
> @@ -150,7 +150,7 @@ void at91_spi0_hw_init(unsigned long cs_mask)
>
> void at91_spi1_hw_init(unsigned long cs_mask)
> {
> - at91_pmc_t *pmc = (at91_pmc_t *) ATMEL_PMC_BASE;
> + at91_pmc_t *pmc = (at91_pmc_t *) ATMEL_BASE_PMC;
>
> at91_set_b_periph(AT91_PIO_PORTA, 21, 0); /* SPI1_MISO */
> at91_set_b_periph(AT91_PIO_PORTA, 22, 0); /* SPI1_MOSI */
I would like to see these two fixes in a separate patch 'fix spi access'
or something else.
rest of this patch looks sane to me.
Best regards
Andreas Bie?mann
next prev parent reply other threads:[~2012-08-16 7:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 4:44 [U-Boot] [PATCH 0/3] Enable at91sam9x5 boot from serial flash Bo Shen
2012-08-16 4:44 ` [U-Boot] [PATCH 1/3] spi: add atmel at25df321 serial flash support Bo Shen
2012-08-17 4:18 ` Mike Frysinger
2012-08-17 5:08 ` Bo Shen
2012-08-17 18:55 ` Mike Frysinger
2012-09-17 17:02 ` Andreas Bießmann
2012-08-16 4:44 ` [U-Boot] [PATCH 2/3] arm : at91sam9x5 : enable serial flash boot Bo Shen
2012-08-16 7:36 ` Andreas Bießmann [this message]
2012-08-16 4:44 ` [U-Boot] [PATCH 3/3] arm : at91sam9x5 : fix a small bug for NAND Bo Shen
2012-08-17 9:26 ` Andreas Bießmann
2012-08-16 7:14 ` [U-Boot] [PATCH 0/3] Enable at91sam9x5 boot from serial flash Bo Shen
2012-08-16 7:37 ` Andreas Bießmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502CA2F7.7080302@gmail.com \
--to=andreas.devel@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.