From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <502CAE74.7060808@metafoo.de> Date: Thu, 16 Aug 2012 10:25:24 +0200 From: Lars-Peter Clausen MIME-Version: 1.0 To: "Kim, Milo" CC: Jonathan Cameron , "jic23@cam.ac.uk" , "linux-kernel@vger.kernel.org" , "linux-iio@vger.kernel.org" Subject: Re: [PATCH 1/3] iio: add iio_read_channel_offset() consumer api References: <502CACFF.3000105@metafoo.de> In-Reply-To: <502CACFF.3000105@metafoo.de> Content-Type: text/plain; charset=ISO-8859-1 List-ID: On 08/16/2012 10:19 AM, Lars-Peter Clausen wrote: > On 08/16/2012 09:39 AM, Kim, Milo wrote: >> This allows the iio consumer to get the offset of the channel. >> The value of offset can be used when calculating the result such >> as 'result = raw * scale + offset'. > > result = (raw + offset) * scale > > Otherwise it looks good, except for: > >> +/** >> + * iio_read_channel_offset() - read offset from a given channel >> + * @channel: The channel being queried. >> + * @val: Offset Value read back. >> + * >> + * Note offset can be used in the consumer when calculating the result >> + * such as 'result = raw * scale + offset'. >> + */ > > The documentation should go in the c file. Just saw that for the other functions in consumer.h it is in the header as well, so ignore that comment above. > >> +int iio_read_channel_offset(struct iio_channel *chan, int *val); >> #endif > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html