From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCH v2 06/11] memcg: kmem controller infrastructure Date: Thu, 16 Aug 2012 13:57:07 +0400 Message-ID: <502CC3F3.5060706@parallels.com> References: <1344517279-30646-1-git-send-email-glommer@parallels.com> <1344517279-30646-7-git-send-email-glommer@parallels.com> <20120814172540.GD6905@dhcp22.suse.cz> <502B6F00.8040207@parallels.com> <20120815130952.GI23985@dhcp22.suse.cz> <502BABCF.7020608@parallels.com> <20120815142338.GL23985@dhcp22.suse.cz> <502BB1E1.5080403@parallels.com> <20120816095309.GB2817@dhcp22.suse.cz> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120816095309.GB2817-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Michal Hocko Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, Johannes Weiner , Andrew Morton , kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org, Christoph Lameter , David Rientjes , Pekka Enberg , Pekka Enberg On 08/16/2012 01:53 PM, Michal Hocko wrote: > On Wed 15-08-12 18:27:45, Glauber Costa wrote: >> >>>> >>>> I see now, you seem to be right. >>> >>> No I am not because it seems that I am really blind these days... >>> We were doing this in mem_cgroup_do_charge for ages: >>> if (!(gfp_mask & __GFP_WAIT)) >>> return CHARGE_WOULDBLOCK; >>> >>> /me goes to hide and get with further feedback with a clean head. >>> >>> Sorry about that. >>> >> I am as well, since I went to look at mem_cgroup_do_charge() and missed >> that. > > I thought we are not doing atomic allocations in user pages accounting > but I was obviously wrong because at least shmem uses atomic > allocations for ages. > >> Do you have any other concerns specific to this patch ? > > I understood you changed also handle thingy. So the patch should be > correct. > Do you plan to send an updated version? > That depends more on you than on me! =) Do you still have any concerns regarding the u+k charging as it stands now? That would be the last big concern I heard during this iteration. If you are happy with the answers you got so far, and believe it is acceptable to proceed with the charging this way, I will be ready to send an updated version soon. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx124.postini.com [74.125.245.124]) by kanga.kvack.org (Postfix) with SMTP id F3A736B0044 for ; Thu, 16 Aug 2012 06:00:17 -0400 (EDT) Message-ID: <502CC3F3.5060706@parallels.com> Date: Thu, 16 Aug 2012 13:57:07 +0400 From: Glauber Costa MIME-Version: 1.0 Subject: Re: [PATCH v2 06/11] memcg: kmem controller infrastructure References: <1344517279-30646-1-git-send-email-glommer@parallels.com> <1344517279-30646-7-git-send-email-glommer@parallels.com> <20120814172540.GD6905@dhcp22.suse.cz> <502B6F00.8040207@parallels.com> <20120815130952.GI23985@dhcp22.suse.cz> <502BABCF.7020608@parallels.com> <20120815142338.GL23985@dhcp22.suse.cz> <502BB1E1.5080403@parallels.com> <20120816095309.GB2817@dhcp22.suse.cz> In-Reply-To: <20120816095309.GB2817@dhcp22.suse.cz> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, devel@openvz.org, Johannes Weiner , Andrew Morton , kamezawa.hiroyu@jp.fujitsu.com, Christoph Lameter , David Rientjes , Pekka Enberg , Pekka Enberg On 08/16/2012 01:53 PM, Michal Hocko wrote: > On Wed 15-08-12 18:27:45, Glauber Costa wrote: >> >>>> >>>> I see now, you seem to be right. >>> >>> No I am not because it seems that I am really blind these days... >>> We were doing this in mem_cgroup_do_charge for ages: >>> if (!(gfp_mask & __GFP_WAIT)) >>> return CHARGE_WOULDBLOCK; >>> >>> /me goes to hide and get with further feedback with a clean head. >>> >>> Sorry about that. >>> >> I am as well, since I went to look at mem_cgroup_do_charge() and missed >> that. > > I thought we are not doing atomic allocations in user pages accounting > but I was obviously wrong because at least shmem uses atomic > allocations for ages. > >> Do you have any other concerns specific to this patch ? > > I understood you changed also handle thingy. So the patch should be > correct. > Do you plan to send an updated version? > That depends more on you than on me! =) Do you still have any concerns regarding the u+k charging as it stands now? That would be the last big concern I heard during this iteration. If you are happy with the answers you got so far, and believe it is acceptable to proceed with the charging this way, I will be ready to send an updated version soon. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932129Ab2HPKAU (ORCPT ); Thu, 16 Aug 2012 06:00:20 -0400 Received: from mx2.parallels.com ([64.131.90.16]:54170 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932092Ab2HPKAS (ORCPT ); Thu, 16 Aug 2012 06:00:18 -0400 Message-ID: <502CC3F3.5060706@parallels.com> Date: Thu, 16 Aug 2012 13:57:07 +0400 From: Glauber Costa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 MIME-Version: 1.0 To: Michal Hocko CC: , , , , Johannes Weiner , Andrew Morton , , Christoph Lameter , David Rientjes , Pekka Enberg , Pekka Enberg Subject: Re: [PATCH v2 06/11] memcg: kmem controller infrastructure References: <1344517279-30646-1-git-send-email-glommer@parallels.com> <1344517279-30646-7-git-send-email-glommer@parallels.com> <20120814172540.GD6905@dhcp22.suse.cz> <502B6F00.8040207@parallels.com> <20120815130952.GI23985@dhcp22.suse.cz> <502BABCF.7020608@parallels.com> <20120815142338.GL23985@dhcp22.suse.cz> <502BB1E1.5080403@parallels.com> <20120816095309.GB2817@dhcp22.suse.cz> In-Reply-To: <20120816095309.GB2817@dhcp22.suse.cz> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/16/2012 01:53 PM, Michal Hocko wrote: > On Wed 15-08-12 18:27:45, Glauber Costa wrote: >> >>>> >>>> I see now, you seem to be right. >>> >>> No I am not because it seems that I am really blind these days... >>> We were doing this in mem_cgroup_do_charge for ages: >>> if (!(gfp_mask & __GFP_WAIT)) >>> return CHARGE_WOULDBLOCK; >>> >>> /me goes to hide and get with further feedback with a clean head. >>> >>> Sorry about that. >>> >> I am as well, since I went to look at mem_cgroup_do_charge() and missed >> that. > > I thought we are not doing atomic allocations in user pages accounting > but I was obviously wrong because at least shmem uses atomic > allocations for ages. > >> Do you have any other concerns specific to this patch ? > > I understood you changed also handle thingy. So the patch should be > correct. > Do you plan to send an updated version? > That depends more on you than on me! =) Do you still have any concerns regarding the u+k charging as it stands now? That would be the last big concern I heard during this iteration. If you are happy with the answers you got so far, and believe it is acceptable to proceed with the charging this way, I will be ready to send an updated version soon.