From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35635) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1y9z-000574-GR for qemu-devel@nongnu.org; Thu, 16 Aug 2012 07:22:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T1y9y-000051-IZ for qemu-devel@nongnu.org; Thu, 16 Aug 2012 07:22:43 -0400 Message-ID: <502CD7F7.1030106@redhat.com> Date: Thu, 16 Aug 2012 14:22:31 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1344930594-18911-1-git-send-email-hong-hua.yin@freescale.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] extract file_load() function from rom_add_file() for reusing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yin Olivia-R63875 Cc: "blauwirbel@gmail.com" , "qemu-ppc@nongnu.org" , "qemu-devel@nongnu.org" On 08/16/2012 02:13 PM, Yin Olivia-R63875 wrote: > Hi Avi & Ben, > > I've got feedback from qemu-ppc list and revised this patch according to Blue's comments. > Could you please give any comments? I don't really have any comments, those files are outside my area of expertise. They look okay to me, but that doesn't mean much as I'm not familiar with ppc. -- error compiling committee.c: too many arguments to function