All of lore.kernel.org
 help / color / mirror / Atom feed
From: Corey Bryant <coreyb@linux.vnet.ibm.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH for-1.2] osdep: Fix compilation failure on BSD systems
Date: Thu, 16 Aug 2012 09:11:19 -0400	[thread overview]
Message-ID: <502CF177.3060007@linux.vnet.ibm.com> (raw)
In-Reply-To: <1345115718-4054-1-git-send-email-peter.maydell@linaro.org>



On 08/16/2012 07:15 AM, Peter Maydell wrote:
> Fix compilation failure on BSD systems (which don't have
> O_DIRECT or O_NOATIME:
> osdep.c:116: error: ‘O_DIRECT’ undeclared (first use in this function)
> osdep.c:116: error: (Each undeclared identifier is reported only once
> osdep.c:116: error: for each function it appears in.)
> osdep.c:116: error: ‘O_NOATIME’ undeclared (first use in this function)
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> PS: Do we care about O_DSYNC, O_RSYNC, O_SYNC? POSIX says those can be
> used via fcntl() too...

Thanks very much Peter.  The patch looks good to me.

Could you point me to the reference you saw the fcntl description in?  I 
didn't notice any flags mentioned here: 
http://pubs.opengroup.org/onlinepubs/009695399/functions/fcntl.html

The choice of flags was based on the Linux man page for fcntl() which 
says F_SETFL can change only the O_APPEND, O_ASYNC, O_DIRECT, O_NOATIME, 
and O_NONBLOCK flags.

-- 
Regards,
Corey

  parent reply	other threads:[~2012-08-16 13:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-16 11:15 [Qemu-devel] [PATCH for-1.2] osdep: Fix compilation failure on BSD systems Peter Maydell
2012-08-16 12:27 ` Stefan Weil
2012-08-16 12:45   ` Peter Maydell
2012-08-16 13:11 ` Corey Bryant [this message]
2012-08-16 13:25   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502CF177.3060007@linux.vnet.ibm.com \
    --to=coreyb@linux.vnet.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=patches@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.