From: Boaz Harrosh <bharrosh@panasas.com>
To: Marco Stornelli <marco.stornelli@gmail.com>
Cc: <bhalevy@tonian.com>, <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
<adilger.kernel@dilger.ca>, <tytso@mit.edu>,
<hirofumi@mail.parknet.co.jp>, <mikulas@artax.karlin.mff.cuni.cz>,
Al Viro <viro@ZenIV.linux.org.uk>, <hch@infradead.org>,
<dushistov@mail.ru>, <osd-dev@open-osd.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
<linux-ext4@vger.kernel.org>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 2/8] exofs: remove lock/unlock super
Date: Thu, 16 Aug 2012 16:23:54 +0300 [thread overview]
Message-ID: <502CF46A.4040507@panasas.com> (raw)
In-Reply-To: <502CC4AA.6040702@gmail.com>
On 08/16/2012 01:00 PM, Marco Stornelli wrote:
> From: Marco Stornelli <marco.stornelli@gmail.com>
>
> Remove lock and unlock super operation.
>
ACK-by: Boaz Harrosh <bharrosh@panasas.com>
> Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
> ---
> diff -Nurp linux-3.6-rc1-orig/fs/exofs/super.c linux-3.6-rc1/fs/exofs/super.c
> --- linux-3.6-rc1-orig/fs/exofs/super.c 2012-08-16 09:37:31.000000000 +0200
> +++ linux-3.6-rc1/fs/exofs/super.c 2012-08-16 09:45:31.000000000 +0200
> @@ -384,8 +384,6 @@ static int exofs_sync_fs(struct super_bl
> if (unlikely(ret))
> goto out;
> - lock_super(sb);
> -
> ios->length = offsetof(struct exofs_fscb, s_dev_table_oid);
> memset(fscb, 0, ios->length);
> fscb->s_nextid = cpu_to_le64(sbi->s_nextid);
> @@ -403,8 +401,6 @@ static int exofs_sync_fs(struct super_bl
> else
> sb->s_dirt = 0;
> -
> - unlock_super(sb);
> out:
> EXOFS_DBGMSG("s_nextid=0x%llx ret=%d\n", _LLU(sbi->s_nextid), ret);
> ore_put_io_state(ios);
prev parent reply other threads:[~2012-08-16 13:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 10:00 [PATCH 2/8] exofs: remove lock/unlock super Marco Stornelli
2012-08-16 12:20 ` Artem Bityutskiy
2012-08-16 12:32 ` Boaz Harrosh
2012-08-16 13:10 ` Artem Bityutskiy
2012-08-16 13:15 ` Boaz Harrosh
2012-08-16 13:23 ` Boaz Harrosh
2012-08-16 13:30 ` Artem Bityutskiy
2012-08-16 13:29 ` Boaz Harrosh
2012-08-16 16:09 ` Marco Stornelli
2012-08-16 13:23 ` Boaz Harrosh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502CF46A.4040507@panasas.com \
--to=bharrosh@panasas.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=bhalevy@tonian.com \
--cc=dushistov@mail.ru \
--cc=hch@infradead.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.stornelli@gmail.com \
--cc=mikulas@artax.karlin.mff.cuni.cz \
--cc=osd-dev@open-osd.org \
--cc=tytso@mit.edu \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.