From: Antti Palosaari <crope@iki.fi>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media <linux-media@vger.kernel.org>
Subject: Re: dvb-usb-v2 change broke s2250-loader compilation
Date: Thu, 16 Aug 2012 16:45:47 +0300 [thread overview]
Message-ID: <502CF98B.1060700@iki.fi> (raw)
In-Reply-To: <502CE527.2070006@iki.fi>
On 08/16/2012 03:18 PM, Antti Palosaari wrote:
> On 08/16/2012 01:33 PM, Hans Verkuil wrote:
>> Building the kernel with the Sensoray 2250/2251 staging go7007 driver
>> enabled
>> fails with this link error:
>>
>> ERROR: "usb_cypress_load_firmware"
>> [drivers/staging/media/go7007/s2250-loader.ko] undefined!
>>
>> As far as I can tell this is related to the dvb-usb-v2 changes.
>>
>> Can someone take a look at this?
>>
>> Thanks!
>>
>> Hans
>
> Yes it is dvb usb v2 related. I wasn't even aware that someone took that
> module use in few days after it was added for the dvb-usb-v2.
>
> Maybe it is worth to make it even more common and move out of dvb-usb-v2...
>
> regards
> Antti
And after looking it twice I cannot see the reason. I split that Cypress
firmware download to own module called dvb_usb_cypress_firmware which
offer routine usbv2_cypress_load_firmware(). Old DVB USB is left
untouched. I can confirm it fails to compile for s2250, but there is
still old dvb_usb_cxusb that is compiling without a error.
Makefile paths seems to be correct also, no idea whats wrong....
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2012-08-16 13:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 10:33 dvb-usb-v2 change broke s2250-loader compilation Hans Verkuil
2012-08-16 12:18 ` Antti Palosaari
2012-08-16 13:45 ` Antti Palosaari [this message]
2012-08-16 14:07 ` Hans Verkuil
2012-08-16 14:29 ` Antti Palosaari
2012-08-16 16:50 ` Mauro Carvalho Chehab
2012-08-16 18:31 ` Antti Palosaari
2012-08-16 18:34 ` Mauro Carvalho Chehab
2012-08-16 18:48 ` Antti Palosaari
2012-08-16 20:06 ` Mauro Carvalho Chehab
2012-08-16 20:41 ` Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502CF98B.1060700@iki.fi \
--to=crope@iki.fi \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.