From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Cc: Paul Eggleton <paul.eggleton@linux.intel.com>
Subject: Re: [PATCH] classes/chrpath: trigger an error if chrpath fails
Date: Thu, 16 Aug 2012 10:06:28 -0700 [thread overview]
Message-ID: <502D2894.1000203@linux.intel.com> (raw)
In-Reply-To: <1345049073-27898-1-git-send-email-paul.eggleton@linux.intel.com>
On 08/15/2012 09:44 AM, Paul Eggleton wrote:
> If chrpath failed here we were just silently ignoring it.
>
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
> meta/classes/chrpath.bbclass | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/chrpath.bbclass b/meta/classes/chrpath.bbclass
> index 10b5ca0..ad61fe0 100644
> --- a/meta/classes/chrpath.bbclass
> +++ b/meta/classes/chrpath.bbclass
> @@ -74,7 +74,9 @@ def process_dir (directory, d):
> if len(new_rpaths):
> args = ":".join(new_rpaths)
> #bb.note("Setting rpath for %s to %s" %(fpath, args))
> - sub.call([cmd, '-r', args, fpath])
> + ret = sub.call([cmd, '-r', args, fpath])
> + if ret != 0:
> + bb.error("chrpath command failed with exit code %d" % ret)
>
> if perms:
> os.chmod(fpath, perms)
>
Merged into OE-Core
Thanks
Sau!
next prev parent reply other threads:[~2012-08-16 17:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 16:44 [PATCH] classes/chrpath: trigger an error if chrpath fails Paul Eggleton
2012-08-16 17:06 ` Saul Wold [this message]
2012-08-16 17:13 ` Paul Eggleton
2012-08-17 9:53 ` Richard Purdie
2012-08-17 10:05 ` Jack Mitchell
2012-08-17 10:26 ` Henning Heinold
2012-08-17 10:53 ` Jack Mitchell
2012-08-17 13:31 ` Paul Eggleton
2012-08-17 16:46 ` Richard Purdie
2012-08-18 0:39 ` Khem Raj
2012-08-17 10:03 ` Phil Blundell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502D2894.1000203@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=paul.eggleton@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.