From: Jonathan Cameron <jic23@kernel.org>
To: "Kim, Milo" <Milo.Kim@ti.com>
Cc: Peter Meerwald <pmeerw@pmeerw.net>,
Lars-Peter Clausen <lars@metafoo.de>,
"jic23@cam.ac.uk" <jic23@cam.ac.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH 1/3] iio: add iio_read_channel_offset() consumer api
Date: Thu, 16 Aug 2012 19:56:49 +0100 [thread overview]
Message-ID: <502D4271.9080104@kernel.org> (raw)
In-Reply-To: <A874F61F95741C4A9BA573A70FE3998F41EEFDA0@DQHE02.ent.ti.com>
On 08/16/2012 08:49 AM, Kim, Milo wrote:
>>> int iio_read_channel_scale(struct iio_channel *chan, int *val,
>>> int *val2);
>>>
>>> +/**
>>> + * iio_read_channel_offset() - read offset from a given channel
>>> + * @channel: The channel being queried.
>>
>> the parameter is 'chan', not 'channel'
>>
>
> Oops, this is copy-and-paste disaster.
> The description of iio_read_channel_scale() also needs correction.
> Thanks for catching this !
good point. Feel free to send a separate patch fixing that ;)
>
> After getting other feedbacks, separate patch will be submitted.
>
> Best Regards,
> Milo
>
next prev parent reply other threads:[~2012-08-16 18:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 7:39 [PATCH 1/3] iio: add iio_read_channel_offset() consumer api Kim, Milo
2012-08-16 7:39 ` Kim, Milo
2012-08-16 7:42 ` Peter Meerwald
2012-08-16 7:49 ` Kim, Milo
2012-08-16 7:49 ` Kim, Milo
2012-08-16 18:56 ` Jonathan Cameron [this message]
2012-08-16 8:19 ` Lars-Peter Clausen
2012-08-16 8:25 ` Lars-Peter Clausen
2012-08-16 8:32 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502D4271.9080104@kernel.org \
--to=jic23@kernel.org \
--cc=Milo.Kim@ti.com \
--cc=jic23@cam.ac.uk \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.