From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45022) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T25g6-0005mk-44 for qemu-devel@nongnu.org; Thu, 16 Aug 2012 15:24:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T25g4-0007ZA-LW for qemu-devel@nongnu.org; Thu, 16 Aug 2012 15:24:22 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:53147) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T25g4-0007YV-Dt for qemu-devel@nongnu.org; Thu, 16 Aug 2012 15:24:20 -0400 Message-ID: <502D48DB.20805@msgid.tls.msk.ru> Date: Thu, 16 Aug 2012 23:24:11 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <20120816145836.GA6793@hq.k1024.org> In-Reply-To: <20120816145836.GA6793@hq.k1024.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] block: handle filenames with colons better List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Iustin Pop Cc: Kevin Wolf , qemu-devel@nongnu.org On 16.08.2012 18:58, Iustin Pop wrote: > Commit 947995c (block: protect path_has_protocol from filenames with > colons) introduced a way to handle filenames with colons based on > whether the path contains a slash or not. IMHO this is not optimal, > since we shouldn't rely on the contents of the path but rather on > whether the given path exists as a file or not. > > As such, this patch tries to handle both files with and without > slashes by falling back to opening them as files if no drivers > supporting the protocol has been identified. I for one dislike this idea entirely: I think there should be a way to stop qemu from trying to open something as a file. It opens a security hole after all, "what if" such a file will actually exist? If I can vote, I'm voting against this with both hands. Thanks, /mjt