From: John Crispin <john@phrozen.org>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 3/3] MIPS: BCM47xx: rewrite GPIO handling and use gpiolib
Date: Thu, 16 Aug 2012 21:35:12 +0200 [thread overview]
Message-ID: <502D4B70.4010509@phrozen.org> (raw)
In-Reply-To: <1345132801-8430-4-git-send-email-hauke@hauke-m.de>
On 16/08/12 18:00, Hauke Mehrtens wrote:
> int gpio_get_value(unsigned gpio)
> +{
> + if (gpio < bcm47xx_gpio_count)
> + return bcm47xx_gpio_in(1 << gpio);
> +
> + return __gpio_get_value(gpio);
> +}
> +EXPORT_SYMBOL(gpio_get_value);
Hi,
You are using a gpio_chip. simply doing this
#define gpio_get_value __gpio_get_value
inside your arch/mips/include/asm/mach-bcm47xx/gpio.h will be enough.
__gpio_get_value() will then automatically find and use
bcm47xx_gpio_get_value() via the gpio_chip.
John
next prev parent reply other threads:[~2012-08-16 19:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 15:59 [PATCH v2 0/3] MIPS: BCM47xx: use gpiolib Hauke Mehrtens
2012-08-16 15:59 ` [PATCH v2 1/3] ssb: add function to return number of gpio lines Hauke Mehrtens
2012-08-16 16:00 ` [PATCH v2 2/3] bcma: add GPIO driver for SoCs Hauke Mehrtens
2012-08-16 16:00 ` [PATCH v2 3/3] MIPS: BCM47xx: rewrite GPIO handling and use gpiolib Hauke Mehrtens
2012-08-16 16:26 ` Florian Fainelli
2012-08-16 17:39 ` Rafał Miłecki
2012-08-16 18:43 ` Arend van Spriel
2012-08-16 19:29 ` Rafał Miłecki
2012-08-16 22:38 ` Hauke Mehrtens
2012-08-16 22:28 ` Hauke Mehrtens
2012-08-16 19:35 ` John Crispin [this message]
2012-08-16 22:33 ` Hauke Mehrtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502D4B70.4010509@phrozen.org \
--to=john@phrozen.org \
--cc=hauke@hauke-m.de \
--cc=linux-mips@linux-mips.org \
--cc=linux-wireless@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.