From: Glauber Costa <glommer@parallels.com>
To: Ying Han <yinghan@google.com>
Cc: Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>, Mel Gorman <mel@csn.ul.ie>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Rik van Riel <riel@redhat.com>, Greg Thelen <gthelen@google.com>,
Christoph Lameter <cl@linux.com>,
KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
linux-mm@kvack.org
Subject: Re: [RFC PATCH 4/6] memcg: shrink dcache with memcg context
Date: Fri, 17 Aug 2012 09:51:01 +0400 [thread overview]
Message-ID: <502DDBC5.3000308@parallels.com> (raw)
In-Reply-To: <1345150448-31073-1-git-send-email-yinghan@google.com>
> diff --git a/include/linux/dcache.h b/include/linux/dcache.h
> index 094789f..624c079 100644
> --- a/include/linux/dcache.h
> +++ b/include/linux/dcache.h
> @@ -120,6 +120,10 @@ struct dentry {
> void *d_fsdata; /* fs-specific data */
>
> struct list_head d_lru; /* LRU list */
> +#ifdef CONFIG_MEMCG_KMEM
> + struct mem_cgroup *d_memcg; /* identify per memcg lru -
> + NULL if not on lru */
> +#endif
> /*
> * d_child and d_rcu can share memory
> */
What I dislike the most about this approach, is the need to come up with
a pointer in the dentry structure.
I am not saying I have a better solution, though...
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-08-17 5:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 20:54 [RFC PATCH 4/6] memcg: shrink dcache with memcg context Ying Han
2012-08-17 5:51 ` Glauber Costa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502DDBC5.3000308@parallels.com \
--to=glommer@parallels.com \
--cc=cl@linux.com \
--cc=gthelen@google.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=mhocko@suse.cz \
--cc=riel@redhat.com \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.