All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marco Stornelli <marco.stornelli@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>, Jan Kara <jack@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>,
	adilger.kernel@dilger.ca, dushistov@mail.ru
Cc: bharrosh@panasas.com, bhalevy@tonian.com,
	hirofumi@mail.parknet.co.jp, mikulas@artax.karlin.mff.cuni.cz,
	Al Viro <viro@ZenIV.linux.org.uk>,
	hch@infradead.org, osd-dev@open-osd.org,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	linux-ext4@vger.kernel.org,
	Linux FS Devel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 3/8] ext3: remove lock/unlock super
Date: Fri, 17 Aug 2012 08:47:04 +0200	[thread overview]
Message-ID: <502DE8E8.5080000@gmail.com> (raw)
In-Reply-To: <20120816191909.GC31346@thunk.org>

Il 16/08/2012 21:19, Theodore Ts'o ha scritto:
> On Thu, Aug 16, 2012 at 06:39:04PM +0200, Jan Kara wrote:
>> On Thu 16-08-12 12:00:26, Marco Stornelli wrote:
>>> From: Marco Stornelli <marco.stornelli@gmail.com>
>>>
>>> Replaced lock and unlock super with a new fs mutex s_lock.
>>    Hum, is the lock needed at all? Remount & unfreeze both run with s_umount
>> held for writing. Thus we already have exclusion between these two calls.
>> The same seems to hold for ext4 BTW.
>
> Agreed, it's not clear lock_super() is needed at all for ext4 at this
> point.
>
> 	     	       		       	      - Ted
>

Great. I'll remove the calls for ext3/ext4 when I'll submit the second 
version of the patch.

Thanks for your feedback,

Marco

  reply	other threads:[~2012-08-17  6:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-16 10:00 [PATCH 3/8] ext3: remove lock/unlock super Marco Stornelli
2012-08-16 16:39 ` Jan Kara
2012-08-16 19:19   ` Theodore Ts'o
2012-08-17  6:47     ` Marco Stornelli [this message]
2012-08-17 23:08       ` Theodore Ts'o
2012-08-18  7:06         ` Marco Stornelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502DE8E8.5080000@gmail.com \
    --to=marco.stornelli@gmail.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=akpm@linux-foundation.org \
    --cc=bhalevy@tonian.com \
    --cc=bharrosh@panasas.com \
    --cc=dushistov@mail.ru \
    --cc=hch@infradead.org \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikulas@artax.karlin.mff.cuni.cz \
    --cc=osd-dev@open-osd.org \
    --cc=tytso@mit.edu \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.