Re: [PATCH v4] hotplug/NetBSD: check type of file to attach from params

[Christoph Egger <Christoph.Egger@amd.com>]

On 08/17/12 10:13, Ian Campbell wrote:

> On Tue, 2012-08-14 at 19:09 +0100, Roger Pau Monne wrote:
>> Changes since v2:
> [...]
>>  * Replace xenstore_write with xenstore-write in error function.
> [...]
>>  error() {
>>  	echo "$@" >&2
>> -	xenstore_write $xpath/hotplug-status error
>> +	xenstore-write $xpath/hotplug-status error
>>  	exit 1
>>  }
> 
> Why this seemingly unrelated change? I don't see anything in the
> comments on v2 explicitly about it.


xenstore-write exists on NetBSD. xenstore_write does not exist.

Christoph

> 
> If it is somehow necessary due to this patch then I think that deserves
> mention in the changelog proper.
> 
> Is it because xenstore_write is actually specific to the Linux hotplug
> scripts? (i.e. this function was just plain broken before).
> 
> While looking into this I noticed that the Linux equivalent to error()
> is:
>         fatal() {
>           _xenstore_write "$XENBUS_PATH/hotplug-error" "$*" \
>                           "$XENBUS_PATH/hotplug-status" error
>           log err "$@"
>           exit 1
>         }
> 
> The write of the log message to hotplus-error seems like something worth
> replicating (in a separate patch).
> 
> I also wonder how much of this sort of infrastructure could actually be
> shared, but that's for another time.
> 
> Ian.
> 
> 



-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632