From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48317) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2KEQ-0000Sj-TE for qemu-devel@nongnu.org; Fri, 17 Aug 2012 06:56:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T2KEP-0008K5-Pg for qemu-devel@nongnu.org; Fri, 17 Aug 2012 06:56:46 -0400 Received: from thoth.sbs.de ([192.35.17.2]:17094) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2KEP-0008Jx-Ej for qemu-devel@nongnu.org; Fri, 17 Aug 2012 06:56:45 -0400 Message-ID: <502E236C.6090508@siemens.com> Date: Fri, 17 Aug 2012 12:56:44 +0200 From: Jan Kiszka MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [RESEND][PATCH for 1.2] i82378: Remove bogus MMIO coalescing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: =?ISO-8859-1?Q?Herv=E9_Poussine?= =?ISO-8859-1?Q?au?= , qemu-devel This MMIO area is an entry gate to legacy PC ISA devices, addressed via PIO over there. Quite a few of the PIO ports have side effects on access like starting/stopping timers that must be executed properly ordered /wrt the CPU. So we have to remove the coalescing mark. Acked-by: Herv=E9 Poussineau Signed-off-by: Jan Kiszka --- hw/i82378.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/i82378.c b/hw/i82378.c index 9b11d90..2123c14 100644 --- a/hw/i82378.c +++ b/hw/i82378.c @@ -225,7 +225,6 @@ static int pci_i82378_init(PCIDevice *dev) pci_register_bar(dev, 0, PCI_BASE_ADDRESS_SPACE_MEMORY, &s->io); =20 memory_region_init_io(&s->mem, &i82378_mem_ops, s, "i82378-mem", 0x0= 1000000); - memory_region_set_coalescing(&s->mem); pci_register_bar(dev, 1, PCI_BASE_ADDRESS_SPACE_MEMORY, &s->mem); =20 /* Make I/O address read only */ --=20 1.7.3.4