All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Zhbanov <i.zhbanov at samsung.com>
To: powertop@lists.01.org
Subject: [Powertop] Some more NaNs in report when CONFIG_TRACING is not enabled
Date: Fri, 17 Aug 2012 15:51:36 +0400	[thread overview]
Message-ID: <502E3048.6020401@samsung.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1354 bytes --]

Hello!

When you run the PowerTOP on the kernel with CONFIG_TRACING disabled,
you will get several NaNs (not a number) in the report. PowerTOP doesn't correctly
handle the situation when /sys/kernel/debug is present but /sys/kernel/debug/tracing is not.

So the PowerTOP will be unable to get information about trace events. And instead of
arguing about that or skipping some tests, it will run and produce wrong reports.

Since there will be no trace events captured, the measurement_time variable
in src/process/do_process.c will remain zero. So the functions like total_wakeups(),
total_gpu_ops(), total_disk_hits(), etc. will happily divide total by zero.

Yes, I know that it is not very useful to run the PowerTOP with tracing disabled (although
the PowerTOP can still report information about devices), but I suppose that the PowerTOP
should check whether /sys/kernel/debug/tracing presents and say something if not.

And as I see the PowerTOP almost never check the result of file opening functions.
If it cannot open a file, the PowerTOP just silently skip it.

Thank you.

-- 
Best regards,
Igor Zhbanov,
Expert Software Engineer,
phone: +7 (495) 797 25 00 ext 3806
e-mail: i.zhbanov(a)samsung.com

ASWG, Moscow R&D center, Samsung Electronics
12 Dvintsev street, building 1
127018, Moscow, Russian Federation


             reply	other threads:[~2012-08-17 11:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-17 11:51 Igor Zhbanov [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-08-17 16:34 [Powertop] Some more NaNs in report when CONFIG_TRACING is not enabled Chris Ferron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502E3048.6020401@samsung.com \
    --to=powertop@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.