From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 1/5] ARM: tegra: config: enable dmaengine based APB DMA driver Date: Fri, 17 Aug 2012 09:17:55 -0600 Message-ID: <502E60A3.1020405@wwwdotorg.org> References: <1345126397-28864-1-git-send-email-ldewangan@nvidia.com> <1345126397-28864-2-git-send-email-ldewangan@nvidia.com> <502D33B6.7070103@wwwdotorg.org> <502DE6FE.8040200@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <502DE6FE.8040200-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Laxman Dewangan Cc: "olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org" , "grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org" , "lrg-l0cyMroinI0@public.gmane.org" , "broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org" , "vinod.koul-VuQAYsv1563Yd54FQh9/CA@public.gmane.org" , "linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , "alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org" List-Id: alsa-devel@alsa-project.org On 08/17/2012 12:38 AM, Laxman Dewangan wrote: > On Thursday 16 August 2012 11:23 PM, Stephen Warren wrote: >> On 08/16/2012 08:13 AM, Laxman Dewangan wrote: >>> Enable config for dmaengine based Tegra APB DMA driver and >>> disable the legacy APB DMA driver (SYSTEM_DMA). >> Laxman, if I apply this series to next-20120816 (plus a few patches in >> my local work branch plus the CPU hotplug patches from Joseph, although >> I suspect none of that matters), then audio playback on Tegra20 is >> broken; the pitch is far too high. Audio playback on Tegra30 works as >> expected. > > I run the test again on ventana and did not see any issue. > I play one song and saw similar behavior with/without this series. OK, I'll test some other boards. I tested Whistler, although all the clocking logic is identical between all Tegra20 boards. > With this series: > -------------------- > > ubuntu@tegra-ubuntu:/home$ aplay "1-04 Hungry Like The Wolf.wav" > Playing WAVE '1-04 Hungry Like The Wolf.wav' : Signed 16 bit Little > Endian, Rate > 44100 Hz, Stereo > underrun!!! (at least 5039.388 ms long) Why are you getting all these underruns? I almost never see this, except when something else is hammering the SD card containing the .wav file. If I saw those, I'd count it as a test failure. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758194Ab2HQPSL (ORCPT ); Fri, 17 Aug 2012 11:18:11 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:60583 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752022Ab2HQPR7 (ORCPT ); Fri, 17 Aug 2012 11:17:59 -0400 Message-ID: <502E60A3.1020405@wwwdotorg.org> Date: Fri, 17 Aug 2012 09:17:55 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0 MIME-Version: 1.0 To: Laxman Dewangan CC: "olof@lixom.net" , "grant.likely@secretlab.ca" , "lrg@ti.com" , "broonie@opensource.wolfsonmicro.com" , "vinod.koul@linux.intel.com" , "linux@arm.linux.org.uk" , "linux-kernel@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "spi-devel-general@lists.sourceforge.net" , "alsa-devel@alsa-project.org" Subject: Re: [PATCH 1/5] ARM: tegra: config: enable dmaengine based APB DMA driver References: <1345126397-28864-1-git-send-email-ldewangan@nvidia.com> <1345126397-28864-2-git-send-email-ldewangan@nvidia.com> <502D33B6.7070103@wwwdotorg.org> <502DE6FE.8040200@nvidia.com> In-Reply-To: <502DE6FE.8040200@nvidia.com> X-Enigmail-Version: 1.5a1pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/17/2012 12:38 AM, Laxman Dewangan wrote: > On Thursday 16 August 2012 11:23 PM, Stephen Warren wrote: >> On 08/16/2012 08:13 AM, Laxman Dewangan wrote: >>> Enable config for dmaengine based Tegra APB DMA driver and >>> disable the legacy APB DMA driver (SYSTEM_DMA). >> Laxman, if I apply this series to next-20120816 (plus a few patches in >> my local work branch plus the CPU hotplug patches from Joseph, although >> I suspect none of that matters), then audio playback on Tegra20 is >> broken; the pitch is far too high. Audio playback on Tegra30 works as >> expected. > > I run the test again on ventana and did not see any issue. > I play one song and saw similar behavior with/without this series. OK, I'll test some other boards. I tested Whistler, although all the clocking logic is identical between all Tegra20 boards. > With this series: > -------------------- > > ubuntu@tegra-ubuntu:/home$ aplay "1-04 Hungry Like The Wolf.wav" > Playing WAVE '1-04 Hungry Like The Wolf.wav' : Signed 16 bit Little > Endian, Rate > 44100 Hz, Stereo > underrun!!! (at least 5039.388 ms long) Why are you getting all these underruns? I almost never see this, except when something else is hammering the SD card containing the .wav file. If I saw those, I'd count it as a test failure.