Re: [PATCH 2/2] ahci_platform: add custom hard reset for Calxeda ahci ctrlr

[Jeff Garzik <jgarzik@pobox.com>]

On 08/17/2012 10:51 AM, Mark Langsdorf wrote:
> Calxeda highbank SATA phy has intermittent problems bringing up a link
> with Gen3 drives. Retrying the phy hard reset can work-around this issue,
> but each reset also disables spread spectrum support. The reset function
> also needs to reprogram the phy to enable spread spectrum support.
>
> Signed-off-by: Mark Langsdorf <mark.langsdorf@calxeda.com>
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> ---
>   .../devicetree/bindings/arm/calxeda/combophy.txt   |   17 ++
>   .../devicetree/bindings/ata/ahci-platform.txt      |    8 +
>   arch/arm/boot/dts/highbank.dts                     |   17 ++
>   drivers/ata/Makefile                               |    1 +
>   drivers/ata/ahci.h                                 |   17 ++
>   drivers/ata/ahci_platform.c                        |   88 ++++++++-
>   drivers/ata/sata_highbank.c                        |  199 ++++++++++++++++++++
>   7 files changed, 339 insertions(+), 8 deletions(-)
>   create mode 100644 Documentation/devicetree/bindings/arm/calxeda/combophy.txt
>   create mode 100644 drivers/ata/sata_highbank.c

This is an odd arrangement:

1) creates a sata_foo.c, which is not a driver but a library.

2) unconditionally burdens all ahci_platform users with Calxeda-specific 
code.

3) #ifndef CONFIG_ARCH_HIGHBANK code wrappers should be 'static inline'

And the biggest issue...

4) if you need all this code for workarounds, just create your own 
libahci driver at that point.  make sata_highbank a real driver.