From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH] ARM: dt: tegra: harmony: add regulators Date: Fri, 17 Aug 2012 13:55:24 -0600 Message-ID: <502EA1AC.4090205@wwwdotorg.org> References: <1345186799-18229-1-git-send-email-ldewangan@nvidia.com> <502E9B09.3080800@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <502E9B09.3080800-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Laxman Dewangan Cc: swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 08/17/2012 01:27 PM, Stephen Warren wrote: > On 08/17/2012 12:59 AM, Laxman Dewangan wrote: >> Harmony uses a TPS6586x regulator. Instantiate this, and hook up a >> couple of fixed GPIO-controlled regulators too. >> >> Based on Ventana regulator patch by Stephen Warren >> and converted to Harmony. > > Thanks, applied to Tegra's for-3.7/dt branch. Oh hang on, this adds regulators to DT, but doesn't do anything to remove the board-file registration of Harmony's regulators from board-dt-tegra20.c, which end up conflicting, and preventing the PCIe driver from being registered. So, this patch really wants to remove the legacy code to, but doing so will be problematic; to avoid runtime git bisect failures, we'd need to merge the regulator tree in first, or wait until next kernel release or something... Thoughts? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758836Ab2HQTzg (ORCPT ); Fri, 17 Aug 2012 15:55:36 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:51847 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754215Ab2HQTz1 (ORCPT ); Fri, 17 Aug 2012 15:55:27 -0400 Message-ID: <502EA1AC.4090205@wwwdotorg.org> Date: Fri, 17 Aug 2012 13:55:24 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0 MIME-Version: 1.0 To: Laxman Dewangan CC: swarren@nvidia.com, olof@lixom.net, linux@arm.linux.org.uk, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH] ARM: dt: tegra: harmony: add regulators References: <1345186799-18229-1-git-send-email-ldewangan@nvidia.com> <502E9B09.3080800@wwwdotorg.org> In-Reply-To: <502E9B09.3080800@wwwdotorg.org> X-Enigmail-Version: 1.5a1pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/17/2012 01:27 PM, Stephen Warren wrote: > On 08/17/2012 12:59 AM, Laxman Dewangan wrote: >> Harmony uses a TPS6586x regulator. Instantiate this, and hook up a >> couple of fixed GPIO-controlled regulators too. >> >> Based on Ventana regulator patch by Stephen Warren >> and converted to Harmony. > > Thanks, applied to Tegra's for-3.7/dt branch. Oh hang on, this adds regulators to DT, but doesn't do anything to remove the board-file registration of Harmony's regulators from board-dt-tegra20.c, which end up conflicting, and preventing the PCIe driver from being registered. So, this patch really wants to remove the legacy code to, but doing so will be problematic; to avoid runtime git bisect failures, we'd need to merge the regulator tree in first, or wait until next kernel release or something... Thoughts?