From: John Crispin <blogic@openwrt.org>
To: dedekind1@gmail.com
Cc: linux-mtd@lists.infradead.org, Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH 1/2] MTD: check for valid pdata inside plat_nand
Date: Fri, 17 Aug 2012 22:52:33 +0200 [thread overview]
Message-ID: <502EAF11.3050207@openwrt.org> (raw)
In-Reply-To: <1345212215.27859.91.camel@sauron.fi.intel.com>
On 17/08/12 16:03, Artem Bityutskiy wrote:
> On Sun, 2012-07-22 at 08:59 +0200, John Crispin wrote:
>> If plat_nand loads and the platform_data is not properly set it will segfault.
>>
>> Signed-off-by: John Crispin <blogic@openwrt.org>
>> Acked-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
>> Cc: linux-mtd@lists.infradead.org
>> ---
>> I am seeing this when plat_nand is referenced inside my DT file but
>> CONFIG_MTD_NAND_XWAY is not selected, resulting in platform_data not being
>> populated with valid data.
> Aiaiai complains like this for this patch-set:
>
> --------------------------------------------------------------------------------
>
> Successfully built configuration "mips-lantiq_defconfig,mips,mips-linux-", results:
>
> --- before_patching.log
> +++ after_patching.log
> @@ @@
> +drivers/mtd/nand/xway_nand.c:145:9: warning: cast removes address space of expression [sparse]
> +drivers/mtd/nand/xway_nand.c:163:25: warning: duplicate const [sparse]
> +drivers/mtd/nand/xway_nand.c:184:12: warning: symbol 'xway_register_nand' was not declared. Should it be static? [sparse]
> +drivers/mtd/nand/xway_nand.c:184:12: warning: no previous prototype for 'xway_register_nand' [-Wmissing-prototypes]
>
> -------------------------------------------------------------------------------
Hi,
shame on me ... we are currently setting up a build bot to run *all*
mips patches through aiaiai so this wont happen in future ...
i will fix the patch and resend it ...
John
next prev parent reply other threads:[~2012-08-17 20:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-22 6:59 [PATCH 1/2] MTD: check for valid pdata inside plat_nand John Crispin
2012-07-22 6:59 ` [PATCH 2/2] MTD: MIPS: lantiq: Add NAND support on Lantiq XWAY SoC John Crispin
2012-07-22 7:07 ` John Crispin
2012-08-15 20:34 ` John Crispin
2012-08-17 14:03 ` [PATCH 1/2] MTD: check for valid pdata inside plat_nand Artem Bityutskiy
2012-08-17 20:52 ` John Crispin [this message]
2012-08-24 14:31 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502EAF11.3050207@openwrt.org \
--to=blogic@openwrt.org \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.