From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52296)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1T2oEf-0004EI-GU
	for qemu-devel@nongnu.org; Sat, 18 Aug 2012 14:59:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1T2oEe-0003co-Cn
	for qemu-devel@nongnu.org; Sat, 18 Aug 2012 14:59:01 -0400
Received: from isrv.corpit.ru ([86.62.121.231]:47722)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1T2oEe-0003br-47
	for qemu-devel@nongnu.org; Sat, 18 Aug 2012 14:59:00 -0400
Message-ID: <502FE5E8.8000905@msgid.tls.msk.ru>
Date: Sat, 18 Aug 2012 22:58:48 +0400
From: Michael Tokarev <mjt@tls.msk.ru>
MIME-Version: 1.0
References: <1344264970-25242-1-git-send-email-pbonzini@redhat.com>
	<502780BB.4000903@msgid.tls.msk.ru> <502FE56F.9010708@redhat.com>
In-Reply-To: <502FE56F.9010708@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] virtio: fix vhost handling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: avi@redhat.com, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

On 18.08.2012 22:56, Paolo Bonzini wrote:
> Il 12/08/2012 12:08, Michael Tokarev ha scritto:
>>>> Commit b1f416aa8d870fab71030abc9401cfc77b948e8e breaks vhost_net
>>>> because it always registers the virtio_pci_host_notifier_read() handler
>>>> function on the ioeventfd, even when vhost_net.ko is using the ioeventfd.
>>>> The result is both QEMU and vhost_net.ko polling on the same eventfd
>>>> and the virtio_net.ko guest driver seeing inconsistent results:
>>>>
>>>>   # ifconfig eth0 192.168.0.1 netmask 255.255.255.0
>>>>   virtio_net virtio0: output:id 0 is not a head!
>>>>
>>>> To fix this, proceed the same as we do for irqfd: add a parameter to
>>>> virtio_queue_set_host_notifier_fd_handler and in that case only set
>>>> the notifier, not the handler.
>> Stable-1.1 material?  The mentioned commit is included into 1.1 release.
> 
> Are you sure?

Oh. Indeed. It is 625 commits after 1.1.0 :)  Sorry for the noize.

/mjt