All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: "Yu, Fenghua" <fenghua.yu@intel.com>
Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
	Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	"Mallick, Asit K" <asit.k.mallick@intel.com>,
	Tigran Aivazian <tigran@aivazian.fsnet.co.uk>,
	Andreas Herrmann <andreas.herrmann3@amd.com>,
	Borislav Petkov <borislav.petkov@amd.com>,
	linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>
Subject: Re: [PATCH 04/11] x86/microcode_core_early.c: Define interfaces for early load ucode
Date: Sat, 18 Aug 2012 22:24:50 -0700	[thread overview]
Message-ID: <503078A2.9030204@zytor.com> (raw)
In-Reply-To: <3E5A0FA7E9CA944F9D5414FEC6C71220077879BF@ORSMSX105.amr.corp.intel.com>

On 08/18/2012 07:38 PM, Yu, Fenghua wrote:
> 
> In this early phase, detecting vendor in initrd is much simpler code.
> Otherwise, detecting vendor by cpuid (and without cpuid) needs
> similar but different code as existing functions and coding would be
> awkward.
> 

I'm confused by this statement.  Getting the vendor from CPUID is a few
lines of code, and non-CPUID processors don't support microcode loading.

> Why name it ".hex" when you're loading binary data?  I suggest ".bin".  It
> is confusing to have .hex there, since you're not dealing with the Intel HEX
> format, nor anything text-like.

Actually I think we can also skip one level of indirection here... no
need to mention "microcode" twice.

kernel/x86/microcode/GenuineIntel or GenuineIntel.bin seems good
enough... the idea here of course is that the string can come from CPUID.

	-hpa

  parent reply	other threads:[~2012-08-19  5:25 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-18  8:15 [PATCH 00/11] x86/microcode: Early load microcode Fenghua Yu
2012-08-18  8:15 ` [PATCH 01/11] Documentation/x86: " Fenghua Yu
2012-08-20 12:26   ` Borislav Petkov
2012-08-18  8:15 ` [PATCH 02/11] x86/lib/cpio.c: Find cpio data by its file name Fenghua Yu
2012-08-18 22:12   ` Henrique de Moraes Holschuh
2012-08-18 23:23     ` Yu, Fenghua
2012-08-19  4:35       ` Henrique de Moraes Holschuh
2012-08-19  5:15         ` H. Peter Anvin
2012-08-20 13:29   ` Borislav Petkov
2012-08-18  8:15 ` [PATCH 03/11] x86/microcode_intel.h: Define functions and macros for early load ucode Fenghua Yu
2012-08-20 13:47   ` Borislav Petkov
2012-08-18  8:15 ` [PATCH 04/11] x86/microcode_core_early.c: Define interfaces " Fenghua Yu
2012-08-18 22:44   ` Henrique de Moraes Holschuh
2012-08-19  2:38     ` Yu, Fenghua
2012-08-19  4:43       ` Henrique de Moraes Holschuh
2012-08-19  5:24       ` H. Peter Anvin [this message]
2012-08-19 16:39         ` Yu, Fenghua
2012-08-20 14:06           ` Borislav Petkov
2012-08-20 20:08             ` H. Peter Anvin
2012-08-20 20:19               ` Borislav Petkov
2012-08-21 20:05                 ` Yu, Fenghua
2012-08-21 20:13                   ` H. Peter Anvin
2012-08-21 20:48                     ` Borislav Petkov
2012-08-21 20:52                       ` H. Peter Anvin
2012-08-21 20:52                       ` Yu, Fenghua
2012-08-21 20:53                         ` H. Peter Anvin
2012-08-21 20:58                           ` Yu, Fenghua
2012-08-20 14:04   ` Borislav Petkov
2012-08-18  8:15 ` [PATCH 05/11] x86/microcode_intel_lib.c: Early update ucode on Intel's CPU Fenghua Yu
2012-08-20 15:31   ` Borislav Petkov
2012-08-20 16:24     ` Borislav Petkov
2012-08-18  8:15 ` [PATCH 06/11] x86/microcode_intel_early.c: " Fenghua Yu
2012-08-18  8:15 ` [PATCH 07/11] x86/head_32.S: Early update ucode in 32-bit Fenghua Yu
2012-08-18  8:15 ` [PATCH 08/11] x86/head64.c: Early update ucode in 64-bit Fenghua Yu
2012-08-18  8:15 ` [PATCH 09/11] x86/smpboot.c: Early update ucode on AP Fenghua Yu
2012-08-18  8:15 ` [PATCH 10/11] x86/mm/init.c: Copy ucode from initrd image to memory Fenghua Yu
2012-08-18  8:15 ` [PATCH 11/11] x86/Kconfig: Configurations to enable/disable the feature Fenghua Yu
2012-08-20 21:41   ` Paul Bolle
2012-08-20 15:39 ` [PATCH 00/11] x86/microcode: Early load microcode Borislav Petkov
2012-08-20 15:44   ` Yu, Fenghua
2012-08-20 18:51   ` H. Peter Anvin
2012-08-20 20:04     ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=503078A2.9030204@zytor.com \
    --to=hpa@zytor.com \
    --cc=andreas.herrmann3@amd.com \
    --cc=asit.k.mallick@intel.com \
    --cc=borislav.petkov@amd.com \
    --cc=fenghua.yu@intel.com \
    --cc=hmh@hmh.eng.br \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=tigran@aivazian.fsnet.co.uk \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.