All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rupesh Gujare <rgujare@ozmodevices.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] staging: ozwpan: fix memcmp() test in oz_set_active_pd()
Date: Sun, 19 Aug 2012 13:06:59 +0000	[thread overview]
Message-ID: <5030E4F3.3050101@ozmodevices.com> (raw)
In-Reply-To: <20120818084759.GB30592@elgon.mountain>

On 19/08/12 13:37, Tomas Winkler wrote:
>> On 18/08/12 09:47, Dan Carpenter wrote:
>>> "addr" is a pointer so it's either 4 or 8 bytes, but actually we want
>>> to compare 6 bytes (ETH_ALEN).
>>>
>>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>> Acked-by: Rupesh Gujare<rgujare@ozmodevices.com>
> why not to use 'if (is_zero_ether_addr())" from linux/etherdevice.h
>
Tom,

Thanks for pointing this out, that looks more efficient. Interested in 
submitting a patch ?

Dan,

What do you think ?


-- 
Regards,
Rupesh Gujare





  parent reply	other threads:[~2012-08-19 13:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-18  8:47 [patch] staging: ozwpan: fix memcmp() test in oz_set_active_pd() Dan Carpenter
2012-08-19 12:15 ` Rupesh Gujare
2012-08-19 12:37 ` Tomas Winkler
2012-08-19 13:06 ` Rupesh Gujare [this message]
2012-08-19 22:23 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5030E4F3.3050101@ozmodevices.com \
    --to=rgujare@ozmodevices.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.