From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
To: florian.achleitner.2.6.31@gmail.com
Cc: GIT Mailing-list <git@vger.kernel.org>
Subject: [PATCH] fast_export.c: Fix a compiler warning
Date: Sun, 19 Aug 2012 16:29:02 +0100 [thread overview]
Message-ID: <5031063E.3090405@ramsay1.demon.co.uk> (raw)
In particular, gcc complains thus:
CC vcs-svn/fast_export.o
vcs-svn/fast_export.c: In function 'fast_export_begin_note':
vcs-svn/fast_export.c:77: warning: long long unsigned int format, \
different type arg (arg 2)
In order to fix the warning, we cast the second size_t argument in
the call to printf to uintmax_t.
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
Hi Florian,
If you need to re-roll your patches in the 'fa/remote-svn' branch, could
you please squash this fix into them. [This was implemented on top of
commit 2ce959ba, but you will probably want to make the equivalent change
to commit d319a37c ("Create a note for every imported commit containing
svn metadata", 17-08-2012) instead. Note that, because of the context
lines in the patch, it won't apply as-is.]
Thanks!
ATB,
Ramsay Jones
vcs-svn/fast_export.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vcs-svn/fast_export.c b/vcs-svn/fast_export.c
index c780d32..dd09c7d 100644
--- a/vcs-svn/fast_export.c
+++ b/vcs-svn/fast_export.c
@@ -74,7 +74,7 @@ void fast_export_begin_note(uint32_t revision, const char *author,
size_t loglen = strlen(log);
printf("commit %s\n", note_ref);
printf("committer %s <%s@%s> %ld +0000\n", author, author, "local", timestamp);
- printf("data %"PRIuMAX"\n", loglen);
+ printf("data %"PRIuMAX"\n", (uintmax_t) loglen);
fwrite(log, loglen, 1, stdout);
if (firstnote) {
if (revision > 1)
--
1.7.11.2
next reply other threads:[~2012-08-19 19:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-19 15:29 Ramsay Jones [this message]
2012-08-20 6:19 ` [PATCH] fast_export.c: Fix a compiler warning Florian Achleitner
2012-08-20 6:50 ` Junio C Hamano
2012-08-21 18:58 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5031063E.3090405@ramsay1.demon.co.uk \
--to=ramsay@ramsay1.demon.co.uk \
--cc=florian.achleitner.2.6.31@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.