From: Jeff Garzik <jgarzik@pobox.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
linux-sparse@vger.kernel.org,
"Christopher Li" <sparse@chrisli.org>,
"Jeff Garzik" <jgarzik@redhat.com>,
"Linus Torvalds" <torvalds@linux-foundation.org>
Subject: Re: [PATCH] sparse, llvm: convert the condition of branch/select to bool
Date: Sun, 19 Aug 2012 12:50:15 -0400 [thread overview]
Message-ID: <50311947.7080700@pobox.com> (raw)
In-Reply-To: <1345387936-25817-1-git-send-email-j.neuschaefer@gmx.net>
On 08/19/2012 10:52 AM, Jonathan Neuschäfer wrote:
> LLVM expects the first argument of "br" and "select" to be of type i1,
> so add an "icmp ne <srcty> %src, 0" for other types.
>
> Cc: Pekka Enberg <penberg@kernel.org>
> Cc: Christopher Li <sparse@chrisli.org>
> Cc: Jeff Garzik <jgarzik@redhat.com>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> ---
> sparse-llvm.c | 13 +++++++++++--
> validation/backend/int-cond.c | 30 ++++++++++++++++++++++++++++++
> 2 files changed, 41 insertions(+), 2 deletions(-)
> create mode 100644 validation/backend/int-cond.c
Nice -- and I wonder if this fixes the loop bug Pekka noted in private
email on 2011/11/23?
Pekka, do you mind if I forward your email to the list?
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-08-19 16:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-19 14:52 [PATCH] sparse, llvm: convert the condition of branch/select to bool Jonathan Neuschäfer
2012-08-19 15:13 ` Pekka Enberg
2012-08-19 16:50 ` Jeff Garzik [this message]
2012-08-19 17:02 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50311947.7080700@pobox.com \
--to=jgarzik@pobox.com \
--cc=j.neuschaefer@gmx.net \
--cc=jgarzik@redhat.com \
--cc=linux-sparse@vger.kernel.org \
--cc=penberg@kernel.org \
--cc=sparse@chrisli.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.