From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonyoung Shim Subject: Re: [PATCH 04/13] drm/exynos: use empty function instead of drm_helper_connector_dpms Date: Mon, 20 Aug 2012 10:12:50 +0900 Message-ID: <50318F12.8020505@samsung.com> References: <1345197059-25583-1-git-send-email-inki.dae@samsung.com> <1345197059-25583-5-git-send-email-inki.dae@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by gabe.freedesktop.org (Postfix) with ESMTP id 5C1299E85E for ; Sun, 19 Aug 2012 18:12:48 -0700 (PDT) Received: from epcpsbgm2.samsung.com (mailout2.samsung.com [203.254.224.25]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0M9100H214OSWVG0@mailout2.samsung.com> for dri-devel@lists.freedesktop.org; Mon, 20 Aug 2012 10:12:47 +0900 (KST) Received: from [10.90.51.60] by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0M91004KB4PA7Z90@mmp2.samsung.com> for dri-devel@lists.freedesktop.org; Mon, 20 Aug 2012 10:12:46 +0900 (KST) In-reply-to: <1345197059-25583-5-git-send-email-inki.dae@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Inki Dae Cc: kyungmin.park@samsung.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 08/17/2012 06:50 PM, Inki Dae wrote: > crtc and encoder's dpms callback will be called before connector's dpms > is called so drm_helper_connector_dpms doesn't need to be called. I can't understand this description. I know crtc and encoder dpms are called by drm_helper_connector_dpms. > Signed-off-by: Inki Dae > Signed-off-by: Kyungmin Park > --- > drivers/gpu/drm/exynos/exynos_drm_connector.c | 9 ++++++++- > 1 files changed, 8 insertions(+), 1 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_connector.c b/drivers/gpu/drm/exynos/exynos_drm_connector.c > index d956819..65acf0d 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_connector.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_connector.c > @@ -226,6 +226,13 @@ static struct drm_connector_helper_funcs exynos_connector_helper_funcs = { > .best_encoder = exynos_drm_best_encoder, > }; > > +static void exynos_drm_connector_dpms(struct drm_connector *connector, int mode) > +{ > + DRM_DEBUG_KMS("%s\n", __FILE__); > + > + /* drm framework doesn't check NULL. */ > +} > + > static int exynos_drm_connector_fill_modes(struct drm_connector *connector, > unsigned int max_width, unsigned int max_height) > { > @@ -285,7 +292,7 @@ static void exynos_drm_connector_destroy(struct drm_connector *connector) > } > > static struct drm_connector_funcs exynos_connector_funcs = { > - .dpms = drm_helper_connector_dpms, > + .dpms = exynos_drm_connector_dpms, > .fill_modes = exynos_drm_connector_fill_modes, > .detect = exynos_drm_connector_detect, > .destroy = exynos_drm_connector_destroy,