From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonyoung Shim Subject: Re: [PATCH 05/13] drm/exynos: removed exynos_drm_encoder_dpms call Date: Mon, 20 Aug 2012 10:14:17 +0900 Message-ID: <50318F69.40307@samsung.com> References: <1345197059-25583-1-git-send-email-inki.dae@samsung.com> <1345197059-25583-6-git-send-email-inki.dae@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by gabe.freedesktop.org (Postfix) with ESMTP id 18EA69E85E for ; Sun, 19 Aug 2012 18:14:15 -0700 (PDT) Received: from epcpsbgm2.samsung.com (mailout4.samsung.com [203.254.224.34]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0M9100A0U4QWCUG0@mailout4.samsung.com> for dri-devel@lists.freedesktop.org; Mon, 20 Aug 2012 10:14:14 +0900 (KST) Received: from [10.90.51.60] by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0M9100JYF4RQBW60@mmp1.samsung.com> for dri-devel@lists.freedesktop.org; Mon, 20 Aug 2012 10:14:14 +0900 (KST) In-reply-to: <1345197059-25583-6-git-send-email-inki.dae@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Inki Dae Cc: kyungmin.park@samsung.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 08/17/2012 06:50 PM, Inki Dae wrote: > encoder's mode_set callback isn't specific to hardware so it doesn't > need to call exynos_drm_encoder_dpms(). Then, where is exynos_drm_encoder_dpms() called? > > Signed-off-by: Inki Dae > Signed-off-by: Kyungmin Park > --- > drivers/gpu/drm/exynos/exynos_drm_encoder.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_encoder.c b/drivers/gpu/drm/exynos/exynos_drm_encoder.c > index 2c037cd..3dae250 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_encoder.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_encoder.c > @@ -138,8 +138,6 @@ static void exynos_drm_encoder_mode_set(struct drm_encoder *encoder, > > DRM_DEBUG_KMS("%s\n", __FILE__); > > - exynos_drm_encoder_dpms(encoder, DRM_MODE_DPMS_ON); > - > list_for_each_entry(connector, &dev->mode_config.connector_list, head) { > if (connector->encoder == encoder) > if (manager_ops && manager_ops->mode_set)