From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3Jyx-0006b6-I0 for qemu-devel@nongnu.org; Mon, 20 Aug 2012 00:52:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3Jyw-0004mP-9l for qemu-devel@nongnu.org; Mon, 20 Aug 2012 00:52:55 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:57022) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3Jyw-0004mK-36 for qemu-devel@nongnu.org; Mon, 20 Aug 2012 00:52:54 -0400 Message-ID: <5031C2A3.3060800@weilnetz.de> Date: Mon, 20 Aug 2012 06:52:51 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1345419579-25499-1-git-send-email-imammedo@redhat.com> In-Reply-To: <1345419579-25499-1-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/5 v2] cpu: make a child of DeviceState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: peter.maydell@linaro.org, jan.kiszka@siemens.com, mjt@tls.msk.ru, qemu-devel@nongnu.org, armbru@redhat.com, blauwirbel@gmail.com, kraxel@redhat.com, xen-devel@lists.xensource.com, i.mitsyanko@samsung.com, mdroth@linux.vnet.ibm.com, avi@redhat.com, anthony.perard@citrix.com, lersek@redhat.com, stefanha@linux.vnet.ibm.com, stefano.stabellini@eu.citrix.com, lcapitulino@redhat.com, rth@twiddle.net, kwolf@redhat.com, aliguori@us.ibm.com, mtosatti@redhat.com, pbonzini@redhat.com, afaerber@suse.de Am 20.08.2012 01:39, schrieb Igor Mammedov: > this is th 3rd approach to make CPU a child of DeviceState > for both kinds of targets *-user and *-softmmu. It seems > with current state of qemu it doesn't take too much effort > to make it compile. Please check if it doesn't break > something on other targets/archs/hosts than i386. > > what's tested: > - compile tested building all targets on FC17x64 host. > - briefly tested i386 user and softmmu targets > > Anthony Liguori (1): > qdev: split up header so it can be used in cpu.h > > Igor Mammedov (4): > move qemu_irq typedef out of cpu-common.h > qapi-types.h doesn't really need to include qemu-common.h > cleanup error.h, included qapi-types.h aready has stdbool.h > make CPU a child of DeviceState > > error.h | 1 - > hw/arm-misc.h | 1 + > hw/bt.h | 2 + > hw/devices.h | 2 + > hw/irq.h | 2 + > hw/mc146818rtc.c | 1 + > hw/omap.h | 1 + > hw/qdev-addr.c | 1 + > hw/qdev-core.h | 240 ++++++++++++++++++++++++++++++++ > hw/qdev-monitor.h | 16 ++ > hw/qdev-properties.c | 1 + > hw/qdev-properties.h | 128 +++++++++++++++++ > hw/qdev.c | 1 + > hw/qdev.h | 371 +------------------------------------------------ > hw/soc_dma.h | 1 + > hw/xen.h | 1 + > include/qemu/cpu.h | 6 +- > qemu-common.h | 1 - > scripts/qapi-types.py | 2 +- > sysemu.h | 1 + > 20 files changed, 407 insertions(+), 373 deletions(-) > create mode 100644 hw/qdev-core.h > create mode 100644 hw/qdev-monitor.h > create mode 100644 hw/qdev-properties.h > I'd prefer if you could keep the following simple pattern: * Start includes in *.c files with config.h (optionally) and qemu-common.h. * Don't include standard include files which are already included in qemu-common.h * Don't include qemu-common.h in *.h files. Regards, Stefan Weil From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Weil Subject: Re: [PATCH 0/5 v2] cpu: make a child of DeviceState Date: Mon, 20 Aug 2012 06:52:51 +0200 Message-ID: <5031C2A3.3060800@weilnetz.de> References: <1345419579-25499-1-git-send-email-imammedo@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1345419579-25499-1-git-send-email-imammedo@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Igor Mammedov Cc: peter.maydell@linaro.org, jan.kiszka@siemens.com, mjt@tls.msk.ru, qemu-devel@nongnu.org, armbru@redhat.com, blauwirbel@gmail.com, kraxel@redhat.com, xen-devel@lists.xensource.com, i.mitsyanko@samsung.com, mdroth@linux.vnet.ibm.com, avi@redhat.com, anthony.perard@citrix.com, lersek@redhat.com, stefanha@linux.vnet.ibm.com, stefano.stabellini@eu.citrix.com, lcapitulino@redhat.com, rth@twiddle.net, kwolf@redhat.com, aliguori@us.ibm.com, mtosatti@redhat.com, pbonzini@redhat.com, afaerber@suse.de List-Id: xen-devel@lists.xenproject.org Am 20.08.2012 01:39, schrieb Igor Mammedov: > this is th 3rd approach to make CPU a child of DeviceState > for both kinds of targets *-user and *-softmmu. It seems > with current state of qemu it doesn't take too much effort > to make it compile. Please check if it doesn't break > something on other targets/archs/hosts than i386. > > what's tested: > - compile tested building all targets on FC17x64 host. > - briefly tested i386 user and softmmu targets > > Anthony Liguori (1): > qdev: split up header so it can be used in cpu.h > > Igor Mammedov (4): > move qemu_irq typedef out of cpu-common.h > qapi-types.h doesn't really need to include qemu-common.h > cleanup error.h, included qapi-types.h aready has stdbool.h > make CPU a child of DeviceState > > error.h | 1 - > hw/arm-misc.h | 1 + > hw/bt.h | 2 + > hw/devices.h | 2 + > hw/irq.h | 2 + > hw/mc146818rtc.c | 1 + > hw/omap.h | 1 + > hw/qdev-addr.c | 1 + > hw/qdev-core.h | 240 ++++++++++++++++++++++++++++++++ > hw/qdev-monitor.h | 16 ++ > hw/qdev-properties.c | 1 + > hw/qdev-properties.h | 128 +++++++++++++++++ > hw/qdev.c | 1 + > hw/qdev.h | 371 +------------------------------------------------ > hw/soc_dma.h | 1 + > hw/xen.h | 1 + > include/qemu/cpu.h | 6 +- > qemu-common.h | 1 - > scripts/qapi-types.py | 2 +- > sysemu.h | 1 + > 20 files changed, 407 insertions(+), 373 deletions(-) > create mode 100644 hw/qdev-core.h > create mode 100644 hw/qdev-monitor.h > create mode 100644 hw/qdev-properties.h > I'd prefer if you could keep the following simple pattern: * Start includes in *.c files with config.h (optionally) and qemu-common.h. * Don't include standard include files which are already included in qemu-common.h * Don't include qemu-common.h in *.h files. Regards, Stefan Weil