All of lore.kernel.org
 help / color / mirror / Atom feed
From: Radu Moisan <radu.moisan@intel.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v2] busybox: Upgrade to upstream 1.20.2
Date: Mon, 20 Aug 2012 12:28:24 +0300	[thread overview]
Message-ID: <50320338.8090203@intel.com> (raw)
In-Reply-To: <1754598.kxQRJyreg5@helios>


On 08/20/2012 11:31 AM, Paul Eggleton wrote:
> On Monday 20 August 2012 09:28:41 Phil Blundell wrote:
>> On Mon, 2012-08-20 at 09:25 +0100, Paul Eggleton wrote:
>>> On Monday 20 August 2012 09:18:17 Phil Blundell wrote:
>>>> On Mon, 2012-08-20 at 10:46 +0300, Radu Moisan wrote:
>>>>> @@ -97,6 +97,8 @@ do_prepare_config () {
>>>>>
>>>>>   		< ${WORKDIR}/defconfig > ${S}/.config
>>>>>   	
>>>>>   	sed -i -e '/CONFIG_STATIC/d' .config
>>>>>   	echo "# CONFIG_STATIC is not set" >> .config
>>>>>
>>>>> +	sed -i -e '/CONFIG_LSOF/d' .config
>>>>> +	echo "# CONFIG_LSOF is not set" >> .config
>>>>>
>>>>>   	for i in 'CROSS' 'DISTRO FEATURES'; do echo "### $i"; done >> \
>>>>>   	
>>>>>   		${S}/.config
>>>>>   	
>>>>>   	sed -i -e '${configmangle}' ${S}/.config
>>>> Why is this desirable?
>>> Well, the more appropriate question would be: could we not just update the
>>> defconfig and then make that change to it directly?
>>>
>>> (In case it isn't clear - lsof is being disabled because it was not
>>> enabled in the previous 1.19.4 version.)
>> Ah, I see.  In that case, yes, just updating the defconfig is the right
>> thing to do.  The patch above will, if I am understanding it correctly,
>> make it impossible (or at least quite hard) for any other layer to turn
>> CONFIG_LSOF back on.
> Good point, that would be undesirable.
Any suggestions on how to do that?

thanks,
radu



  reply	other threads:[~2012-08-20  9:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-20  7:46 [PATCH v2] busybox: Upgrade to upstream 1.20.2 Radu Moisan
2012-08-20  8:18 ` Phil Blundell
2012-08-20  8:25   ` Paul Eggleton
2012-08-20  8:28     ` Phil Blundell
2012-08-20  8:31       ` Paul Eggleton
2012-08-20  9:28         ` Radu Moisan [this message]
2012-08-20  9:29           ` Paul Eggleton
2012-08-20  9:31           ` Phil Blundell
2012-08-20 13:02             ` Anders Darander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50320338.8090203@intel.com \
    --to=radu.moisan@intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.