From: Avi Kivity <avi@redhat.com>
To: "Roedel, Joerg" <Joerg.Roedel@amd.com>
Cc: "Hao, Xudong" <xudong.hao@intel.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Zhang, Xiantao" <xiantao.zhang@intel.com>
Subject: Re: [PATCH] kvm/fpu: Enable fully eager restore kvm FPU
Date: Mon, 20 Aug 2012 13:08:14 +0300 [thread overview]
Message-ID: <50320C8E.6040109@redhat.com> (raw)
In-Reply-To: <20120820092416.GB2582@amd.com>
On 08/20/2012 12:24 PM, Roedel, Joerg wrote:
> (Back from vacation)
>
> On Thu, Aug 16, 2012 at 01:59:02PM +0300, Avi Kivity wrote:
>> Ok. Please check that ~KVM_XSTATE_LAZY expands to 64-bits correctly,
>> maybe we need to cast it to u64 before negating it.
>>
>> Note that we limit xcr0 to the bits allowed by the host, so the currect
>> kernel is safe even on hardware with state that isn't tracked by cr0.ts.
>> But it's better to be safe here.
>>
>> Joerg, IIRC LWP uses one of these bits? Should it be added to the mask?
>
> LWP uses bit 62 in xcr0 and is not tracked by cr0.ts either. So this bit
> should be used to the mask too (in other words LWP is a non-lazy state).
So it was broken all along? Yikes.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-08-20 10:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 5:14 [PATCH] kvm/fpu: Enable fully eager restore kvm FPU Xudong Hao
2012-08-16 9:08 ` Avi Kivity
2012-08-16 9:48 ` Hao, Xudong
2012-08-16 10:59 ` Avi Kivity
2012-08-16 11:50 ` Hao, Xudong
2012-08-20 9:24 ` Roedel, Joerg
2012-08-20 10:08 ` Avi Kivity [this message]
2012-08-20 10:14 ` Roedel, Joerg
2012-08-20 10:43 ` Avi Kivity
2012-08-20 10:53 ` Roedel, Joerg
2012-08-23 8:51 ` Hao, Xudong
2012-09-03 9:23 ` Avi Kivity
2012-09-05 1:10 ` Hao, Xudong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50320C8E.6040109@redhat.com \
--to=avi@redhat.com \
--cc=Joerg.Roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=xiantao.zhang@intel.com \
--cc=xudong.hao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.