Re: [Qemu-devel] [PATCH v2 00/12] Portable thread-pool/AIO, Win32 emulated AIO

[Paolo Bonzini <pbonzini@redhat.com>]

Il 13/08/2012 21:43, Stefan Weil ha scritto:
>>
>> Label out_free_buf is only used with CONFIG_LINUX_AIO.
>>
>> off_t is always 32 bit with MinGW header files, but we
>> want support for large files, so off64_t is a better choice
>> here. It also avoids a compiler warning when the value
>> is right shifted by 32 bits.

Thanks, I squashed these in.

>> I noticed some messages from checkpatch.pl.
>> Some (but not all) of them were caused by the renamed file.
>> Maybe this file should be fixed before it is renamed.

If you make "git diff" detect renames they should go away.

> More changes are needed for user mode emulation.
> I hope they don't break linking of other executables:

There's need for more cleanup here, indeed.  qemu-ga is including a lot
of unnecessary cruft via tools-obj-y (where it only needs tracing and
oslib, basically).  cutils.c/iov.c are unnecessarily intertwined and
user mode emulation has no business including either.  It should also
not need event_notifier.c.

Paolo