[Qemu-devel] For 1.2: Re: [PATCH] qapi: add 'query-target' command to return target arch/bit size

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1484 bytes --]

On 08/20/2012 08:31 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange@redhat.com>
> 
> Add a 'query-target' QAPI command to allow management applications
> to determine what target architecture a QEMU binary is emulating
> without having to parse the binary name or -help output
> 
>   $ qmp-shell -p /tmp/qemu
>   (QEMU) query-target
>   {   u'return': {   u'arch': u'x86_64', u'bits': 64}}
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  arch_init.c      | 11 +++++++++++
>  qapi-schema.json | 25 +++++++++++++++++++++++++
>  qmp-commands.hx  |  5 +++++
>  3 files changed, 41 insertions(+)

Adding the for 1.2 marking in the subject, to make it clear that this is
a "bug fix" for the fact that Anthony's QMP additions for libvirt were
incomplete, and should be pulled in now rather than delayed to 1.3.

> +##
> +# @TargetInfo:
> +#
> +# Information describing the QEMU target.
> +#
> +# @arch: the name of the target architecture (eg "x86_64", "i686", etc)

s/eg/e.g./ (it is an abbreviation of the two-word phrase exempli gratia)

Or even better, since mixing 'e.g.' and 'etc.' in the same sentence
sounds stupid, just go with the much simpler:

@arch: the name of the target architecture (such as "x86_64" or "i686")

> +# @bits: number of bits in physical address (eg 32 or 64)

Ditto.

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]