From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] virtio-scsi spec: add per-LUN parameter query Date: Mon, 20 Aug 2012 17:57:28 +0200 Message-ID: <50325E68.6080401@redhat.com> References: <1345453404-15244-1-git-send-email-mc@linux.vnet.ibm.com> <50323926.8000205@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: McPacino Cc: stefanha@linux.vnet.ibm.com, zwanp@cn.ibm.com, linuxram@us.ibm.com, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, Cong Meng List-Id: virtualization@lists.linuxfoundation.org SWwgMjAvMDgvMjAxMiAxNjo0NCwgTWNQYWNpbm8gaGEgc2NyaXR0bzoKPiAKPiDlnKggMjAxMi04 LTIwIOS4i+WNiDk6MTjvvIwiUGFvbG8gQm9uemluaSIgPHBib256aW5pQHJlZGhhdC5jb20KPiA8 bWFpbHRvOnBib256aW5pQHJlZGhhdC5jb20+PuWGmemBk++8mgo+Pgo+PiBJbCAyMC8wOC8yMDEy IDExOjAzLCBDb25nIE1lbmcgaGEgc2NyaXR0bzoKPj4gPiBFYWNoIHZpcnRpbyBzY3NpIEhCQSBo YXMgZ2xvYmFsIHJlcXVlc3QgcXVldWUgbGltaXRzLiBCdXQgdGhlCj4gcGFzc3Rocm91Z2gKPj4g PiBMVU5zIChzY3NpLWdlbmVyaWMpIGNvbWUgZnJvbSBkaWZmZXJlbnQgaG9zdCBIQkFzIG1heSBo YXZlIGRpZmZlcmVudAo+IHJlcXVlc3QKPj4gPiBxdWV1ZSBsaW1pdHMuIElmIHRoZSBndWVzdCBz ZW5kcyBjb21tYW5kcyB0aGF0IGV4Y2VlZCB0aGUgaG9zdAo+IGxpbWl0cywgdGhlCj4+ID4gY29t bWFuZHMgd2lsbCBiZSByZWplY3RlZCBieSBob3N0IEhBQi4KPj4gPgo+PiA+IFRvIGFkZHJlc3Mg dGhpcyBpc3N1ZSwgdGhpcyBwYXRjaCBhZGRzIGEgcGVyLUxVTiBwYXJhbWV0ZXIgcXVlcnkgdmlh Cj4gdGhlIGNvbnRyb2wKPj4gPiBxdWV1ZSwgYW5kIGRlZmluZXMgc29tZSBwYXJhbWV0ZXIgcXVl cnkgdHlwZXMuIFRoZSBkcml2ZXIgY2FuIHF1ZXJ5Cj4gYW5kIHNldCB0aGUKPj4gPiBuZWVkZWQg cGVyLUxVTiBwYXJhbWV0ZXJzIGlmIHRoZSBkZXZpY2UgZW5hYmxlcyB0aGlzIGZlYXR1cmUuCj4+ ID4KPj4gPiBTaWduZWQtb2ZmLWJ5OiBDb25nIE1lbmcgPG1jQGxpbnV4LnZuZXQuaWJtLmNvbQo+ IDxtYWlsdG86bWNAbGludXgudm5ldC5pYm0uY29tPj4KPj4gPiAtLQo+PiA+ICB2aXJ0aW8tc3Bl Yy5seXggfCAgMjE4Cj4gKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKwo+PiA+ICAxIGZpbGVzIGNoYW5nZWQsIDIxOCBpbnNlcnRpb25zKCspLCAw IGRlbGV0aW9ucygtKQo+Pgo+PiBEbyB5b3UgaGF2ZSBrZXJuZWwgYW5kIFFFTVUgcGF0Y2hlcyBm b3IgdGhpcz8gIFRoYXQgd291bGQgaGVscCBtZQo+PiBldmFsdWF0ZSB3aGV0aGVyIHRoZSBpbnRl cmZhY2UgaXMgdGhlIGNvcnJlY3Qgb25lLgo+Pgo+IHllcyxJIGhhdmUgYSBkZW1vLiBJIHdpbGwg cG9zdCBpdCBhZnRlciBJIHBvbGlzaCBpdCB0b21vcnJvdy4KPiAKPj4gSW4gYW55IGNhc2UsIEkn ZCByYXRoZXIgaGF2ZSBhIHNpbmdsZSBjb21tYW5kIHJldHVybmluZyBhbGwgdGhyZWUgdmFsdWVz Cj4+IChWSVJUSU9fU0NTSV9UX0xVTl9RVUVVRV9QQVJBTVMpLCBzaW5jZSBpdCdzIHVubGlrZWx5 IHRoYXQgeW91IG5lZWQganVzdAo+PiBvbmUuCj4gCj4gSSBpbnRlbmQgdG8gc2VwZXJhdCB0aGVt IG9uZSBieSBvbmUuIEFzIHRoZXJlIGlzIG9wcG9ydHVuaXR5IHRoYXQgb3RoZXIKPiBuZXcgcGFy YW1ldGVycyBhcmUgbmVlZGVkIGZvciBvdGhlciBmZWF0dXJlcy4KCllvdSBjYW4gdXNlIG1vcmUg ZmVhdHVyZSBiaXRzIHRvIGRpY3RhdGUgd2hpY2ggYml0cyBhcmUgcHJlc2VudC4KClBhb2xvCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpWaXJ0dWFsaXph dGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlzdHMubGludXgtZm91bmRhdGlvbi5v cmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vdmly dHVhbGl6YXRpb24= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58523) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3UMI-0007e0-Cd for qemu-devel@nongnu.org; Mon, 20 Aug 2012 11:57:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3UM8-0000VD-3l for qemu-devel@nongnu.org; Mon, 20 Aug 2012 11:57:42 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:58938) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3UM7-0000V1-Tb for qemu-devel@nongnu.org; Mon, 20 Aug 2012 11:57:32 -0400 Received: by wibhm2 with SMTP id hm2so2943677wib.10 for ; Mon, 20 Aug 2012 08:57:31 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <50325E68.6080401@redhat.com> Date: Mon, 20 Aug 2012 17:57:28 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1345453404-15244-1-git-send-email-mc@linux.vnet.ibm.com> <50323926.8000205@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] virtio-scsi spec: add per-LUN parameter query List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: McPacino Cc: stefanha@linux.vnet.ibm.com, zwanp@cn.ibm.com, linuxram@us.ibm.com, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, Cong Meng Il 20/08/2012 16:44, McPacino ha scritto: > > 在 2012-8-20 下午9:18，"Paolo Bonzini" >写道： >> >> Il 20/08/2012 11:03, Cong Meng ha scritto: >> > Each virtio scsi HBA has global request queue limits. But the > passthrough >> > LUNs (scsi-generic) come from different host HBAs may have different > request >> > queue limits. If the guest sends commands that exceed the host > limits, the >> > commands will be rejected by host HAB. >> > >> > To address this issue, this patch adds a per-LUN parameter query via > the control >> > queue, and defines some parameter query types. The driver can query > and set the >> > needed per-LUN parameters if the device enables this feature. >> > >> > Signed-off-by: Cong Meng > >> > -- >> > virtio-spec.lyx | 218 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> > 1 files changed, 218 insertions(+), 0 deletions(-) >> >> Do you have kernel and QEMU patches for this? That would help me >> evaluate whether the interface is the correct one. >> > yes,I have a demo. I will post it after I polish it tomorrow. > >> In any case, I'd rather have a single command returning all three values >> (VIRTIO_SCSI_T_LUN_QUEUE_PARAMS), since it's unlikely that you need just >> one. > > I intend to seperat them one by one. As there is opportunity that other > new parameters are needed for other features. You can use more feature bits to dictate which bits are present. Paolo