All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Cc: Matthew McClintock <msm@freescale.com>
Subject: Re: [PATCH] perf_3.4.bb: update to build against older kernels
Date: Mon, 20 Aug 2012 09:57:07 -0700	[thread overview]
Message-ID: <50326C63.1070101@linux.intel.com> (raw)
In-Reply-To: <1345172096-10260-1-git-send-email-msm@freescale.com>

On 08/16/2012 07:54 PM, Matthew McClintock wrote:
> Removes a make install-python_ext when not present since
> older versions of perf lack this install rule
>
> This also fixes a library issue on older kernels building with
> a newer toolchain where libaries that would previously be pulled
> in are no longer. So we add them manually.
>
> Signed-off-by: Matthew McClintock <msm@freescale.com>
> ---
>   meta/recipes-kernel/perf/perf_3.4.bb |    4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-kernel/perf/perf_3.4.bb b/meta/recipes-kernel/perf/perf_3.4.bb
> index 505c7b8..5fb38e6 100644
> --- a/meta/recipes-kernel/perf/perf_3.4.bb
> +++ b/meta/recipes-kernel/perf/perf_3.4.bb
> @@ -54,6 +54,7 @@ B = "${WORKDIR}/${BPN}-${PV}"
>   SCRIPTING_DEFINES = "${@perf_feature_enabled('perf-scripting', '', 'NO_LIBPERL=1 NO_LIBPYTHON=1',d)}"
>   TUI_DEFINES = "${@perf_feature_enabled('perf-tui', '', 'NO_NEWT=1',d)}"
>
> +export LDFLAGS = "-ldl -lutil"
>   EXTRA_OEMAKE = \
>   		'-C ${S}/tools/perf \
>   		O=${B} \
> @@ -71,7 +72,8 @@ do_compile() {
>
>   do_install() {
>   	oe_runmake DESTDIR=${D} install
> -	if [ "${@perf_feature_enabled('perf-scripting', 1, 0, d)}" = "1" ]; then
> +	# we are checking for this make target to be compatible with older perf versions
> +	if [ "${@perf_feature_enabled('perf-scripting', 1, 0, d)}" = "1" -a $(grep install-python_ext ${S}/tools/perf/Makefile) = "0"]; then
>   		oe_runmake DESTDIR=${D} install-python_ext
>   	fi
>   }
>

Merged into OE-Core

Thanks
	Sau!




      reply	other threads:[~2012-08-20 17:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-17  2:54 [PATCH] perf_3.4.bb: update to build against older kernels Matthew McClintock
2012-08-20 16:57 ` Saul Wold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50326C63.1070101@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=msm@freescale.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.