From: Avi Kivity <avi@redhat.com>
To: "Yan, Zheng" <zheng.z.yan@linux.intel.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Pekka Enberg <penberg@kernel.org>,
Sasha Levin <levinsasha928@gmail.com>,
Asias He <asias.hejun@gmail.com>,
Cyrill Gorcunov <gorcunov@gmail.com>, Ingo Molnar <mingo@elte.hu>,
KVM General <kvm@vger.kernel.org>, Gleb Natapov <gleb@redhat.com>
Subject: Re: perf uncore & lkvm woes
Date: Tue, 21 Aug 2012 11:32:01 +0300 [thread overview]
Message-ID: <50334781.4020903@redhat.com> (raw)
In-Reply-To: <5032E02F.7060104@linux.intel.com>
On 08/21/2012 04:11 AM, Yan, Zheng wrote:
>>> There is only one kvm_pmu structure in struct kvm_vcpu_arch, but the uncore
>>> driver may define dozens of PMUs. Besides the uncore PMUs make extensive use
>>> of extra registers, I don't think we can store these information in kvm_pmu
>>> structure.
>>
>> We don't need to store any information, just respond to those MSRs (and
>> ignore them).
>
> The problem is that there are hundreds of MSRs, but only a few of them are
> defined in the header file of uncore driver. The uncore driver computes
> addresses of the rest MSRs by using uncore box index and counter index.
You can do the same in kvm. Maybe even move the functions that compute
the addresses to a header, so that they can be shared.
Can you point me at the code? Maybe I'm misunderstanding something here.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-08-21 8:32 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 7:01 perf uncore & lkvm woes Pekka Enberg
2012-08-16 7:07 ` Cyrill Gorcunov
2012-08-16 7:16 ` Cyrill Gorcunov
2012-08-16 7:16 ` Pekka Enberg
2012-08-16 7:19 ` Peter Zijlstra
2012-08-16 7:38 ` Yan, Zheng
2012-08-16 7:41 ` Pekka Enberg
2012-08-16 7:46 ` Cyrill Gorcunov
2012-08-16 8:45 ` Avi Kivity
2012-08-16 9:06 ` Cyrill Gorcunov
2012-08-16 9:23 ` Pekka Enberg
2012-08-16 8:40 ` Avi Kivity
2012-08-16 11:06 ` Avi Kivity
2012-08-16 11:17 ` Peter Zijlstra
2012-08-16 11:25 ` Avi Kivity
2012-08-17 1:40 ` Yan, Zheng
2012-08-17 6:56 ` Peter Zijlstra
2012-08-19 9:55 ` Avi Kivity
2012-08-20 4:15 ` Yan, Zheng
2012-08-20 8:49 ` Avi Kivity
2012-08-21 1:11 ` Yan, Zheng
2012-08-21 8:32 ` Avi Kivity [this message]
2012-08-21 9:07 ` Yan, Zheng
2012-08-20 5:30 ` Yan, Zheng
2012-08-20 8:48 ` Avi Kivity
2012-08-21 7:11 ` Peter Zijlstra
2012-08-21 8:34 ` Avi Kivity
2012-08-21 10:35 ` Peter Zijlstra
2012-08-22 8:53 ` Avi Kivity
2012-08-16 14:28 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50334781.4020903@redhat.com \
--to=avi@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=asias.hejun@gmail.com \
--cc=gleb@redhat.com \
--cc=gorcunov@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
--cc=zheng.z.yan@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.