From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v2] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create() Date: Tue, 21 Aug 2012 12:27:51 +0200 Message-ID: <503362A7.4010106@siemens.com> References: <1345028893-2388-1-git-send-email-peter.maydell@linaro.org> <5033449B.40400@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: "patches@linaro.org" , Marcelo Tosatti , "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" , Avi Kivity To: Peter Maydell Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 2012-08-21 10:25, Peter Maydell wrote: > On 21 August 2012 09:19, Jan Kiszka wrote: >> On 2012-08-15 13:08, Peter Maydell wrote: >>> Move the init of the irqchip_inject_ioctl field of KVMState out of >>> kvm_irqchip_create() and into kvm_init(), so that kvm_set_irq() >>> can be used even when no irqchip is created (for architectures >>> that support async interrupt notification even without an in >>> kernel irqchip). > >> As it's not yet merged, some late comment: irqchip_inject_ioctl should >> be renamed as well. irq_inject_ioctl? > > If we're changing it anyway, IIRC Avi didn't like the term "inject" > here? Then irq_set_ioctl. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40466) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3lgq-0002Bl-1M for qemu-devel@nongnu.org; Tue, 21 Aug 2012 06:28:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3lgo-000331-TK for qemu-devel@nongnu.org; Tue, 21 Aug 2012 06:28:03 -0400 Received: from thoth.sbs.de ([192.35.17.2]:29863) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3lgo-00032V-KD for qemu-devel@nongnu.org; Tue, 21 Aug 2012 06:28:02 -0400 Message-ID: <503362A7.4010106@siemens.com> Date: Tue, 21 Aug 2012 12:27:51 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1345028893-2388-1-git-send-email-peter.maydell@linaro.org> <5033449B.40400@siemens.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: "patches@linaro.org" , Marcelo Tosatti , "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" , Avi Kivity On 2012-08-21 10:25, Peter Maydell wrote: > On 21 August 2012 09:19, Jan Kiszka wrote: >> On 2012-08-15 13:08, Peter Maydell wrote: >>> Move the init of the irqchip_inject_ioctl field of KVMState out of >>> kvm_irqchip_create() and into kvm_init(), so that kvm_set_irq() >>> can be used even when no irqchip is created (for architectures >>> that support async interrupt notification even without an in >>> kernel irqchip). > >> As it's not yet merged, some late comment: irqchip_inject_ioctl should >> be renamed as well. irq_inject_ioctl? > > If we're changing it anyway, IIRC Avi didn't like the term "inject" > here? Then irq_set_ioctl. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux