From: Rob Herring <robherring2@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Chris Ball <cjb@laptop.org>,
Thomas Abraham <thomas.abraham@linaro.org>,
linux-mmc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-samsung-soc@vger.kernel.org, grant.likely@secretlab.ca,
patches@linaro.org
Subject: Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding
Date: Tue, 21 Aug 2012 09:21:47 -0500 [thread overview]
Message-ID: <5033997B.9010605@gmail.com> (raw)
In-Reply-To: <201208211208.49987.arnd@arndb.de>
On 08/21/2012 07:08 AM, Arnd Bergmann wrote:
> On Tuesday 21 August 2012, Chris Ball wrote:
>> How about this?
>>
>> broken-cd: No CD available, use polling.
>>
>> cd-gpios: The CD pin on the host is working and brought out to a GPIO.
>>
>> external-cd-gpios: The CD pin on the host is broken, but there's an
>> independent external GPIO available.
>>
>>
>> (Each host should only have one of these properties.)
>
> The fsl-imx-esdhc.txt binding already has all three cases, but
> describes them differently:
>
> fsl,cd-internal: when present, the CD pin on the host is working
> cd-gpios: when present, contains the gpio line that CD is connected to
> If both are absent, it has to use polling.
This makes the most sense to me. However, I prefer broken-cd over
cd-internal. The binding should add properties for exceptions, not SDHCI
spec compliant implementations.
Rob
next prev parent reply other threads:[~2012-08-21 14:21 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 11:09 [PATCH] mmc: dt: Add 'broken-cd' DT binding Thomas Abraham
2012-08-21 11:01 ` Arnd Bergmann
2012-08-21 11:14 ` Chris Ball
2012-08-21 11:14 ` Thomas Abraham
2012-08-21 11:56 ` Chris Ball
2012-08-21 12:08 ` Arnd Bergmann
2012-08-21 14:21 ` Rob Herring [this message]
2012-08-21 14:48 ` Chris Ball
2012-08-21 15:03 ` Rob Herring
2012-08-21 15:18 ` Chris Ball
2012-08-21 16:01 ` Rob Herring
2012-08-21 17:33 ` Thomas Abraham
[not found] ` <CAJuYYwR+oCQUcgoy6ZuHp0XAa+EAj9d-FvLtwsQcP3muFMrKLA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-08-21 18:32 ` Mitch Bradley
2012-08-22 5:51 ` Shawn Guo
2012-08-22 10:17 ` Chris Ball
2012-08-22 10:51 ` Thomas Abraham
2012-08-22 11:08 ` Chris Ball
2012-08-22 12:04 ` Thomas Abraham
2012-08-22 14:54 ` Chris Ball
2012-08-22 14:59 ` Thomas Abraham
2012-08-22 18:05 ` [PATCH] mmc: dt: Add card-detection properties to core binding Chris Ball
2012-08-24 5:44 ` Shawn Guo
[not found] ` <CAJuYYwQLUs5qb8NqtPf3=ytNHJ_VdnN8Z4yWwyk2+OTftdWFXw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-08-22 17:09 ` [PATCH] mmc: dt: Add 'broken-cd' DT binding Mitch Bradley
2012-08-23 6:59 ` Thomas Abraham
2012-08-22 14:54 ` Stephen Warren
2012-08-22 14:58 ` Chris Ball
2012-08-21 15:21 ` Thomas Abraham
2012-08-22 6:00 ` Shawn Guo
2012-08-22 12:26 ` Shawn Guo
2012-08-22 13:54 ` Chris Ball
2012-08-21 12:30 ` Thomas Abraham
2012-08-21 11:09 ` Thomas Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5033997B.9010605@gmail.com \
--to=robherring2@gmail.com \
--cc=arnd@arndb.de \
--cc=cjb@laptop.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.