All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Elder <elder@inktank.com>
To: ceph-devel <ceph-devel@vger.kernel.org>
Subject: Fwd: Re: [PATCH 2/4] ceph: tolerate (and warn on) extraneous dentry from mds
Date: Tue, 21 Aug 2012 15:02:29 -0500	[thread overview]
Message-ID: <5033E955.7030906@inktank.com> (raw)
In-Reply-To: <5033E93D.3050802@inktank.com>

Forgot to copy the list.  Sorry.	-Alex


-------- Original Message --------
Subject: Re: [PATCH 2/4] ceph: tolerate (and warn on) extraneous dentry
from mds
Date: Tue, 21 Aug 2012 15:02:05 -0500
From: Alex Elder <elder@inktank.com>
To: Sage Weil <sage@inktank.com>

On 08/21/2012 02:19 PM, Sage Weil wrote:
> If the MDS gives us a dentry and we weren't prepared to handle it,
> WARN_ON_ONCE instead of crashing.
> 
> Reported-by: Yan, Zheng <zheng.z.yan@intel.com>
> Signed-off-by: Sage Weil <sage@inktank.com>

The fix looks good to me, but I confess I did not follow the
calling paths through well enough to know when we might see
a null d_locked_dir.

Reviewed-by: Alex Elder <elder@inktank.com>

. . .




           reply	other threads:[~2012-08-21 20:02 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <5033E93D.3050802@inktank.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5033E955.7030906@inktank.com \
    --to=elder@inktank.com \
    --cc=ceph-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.