From: Jan Kiszka <jan.kiszka@web.de>
To: Cam Macdonell <cam@cs.ualberta.ca>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Avi Kivity <avi@redhat.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] ivshmem assertion failure with EventNotifier
Date: Wed, 22 Aug 2012 10:05:24 +0200 [thread overview]
Message-ID: <503492C4.6080207@web.de> (raw)
In-Reply-To: <CAKjmthLA0fUJ29ov4EqVHbC+fuYtOzxgWX5r+s_G-sJGpWYGGg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]
On 2012-08-22 06:29, Cam Macdonell wrote:
> Hi Paolo,
>
> I've noticed an assertion error when sending interrupts via ivshmem.
> I bisected to this patch.
>
> commit 563027cc0c94aa4846c18f9d665a4c90f8c42ba8
> Author: Paolo Bonzini <pbonzini@redhat.com>
> Date: Thu Jul 5 17:16:25 2012 +0200
>
> ivshmem: use EventNotifier and memory API
>
> All of ivshmem's usage of eventfd now has a corresponding API in
> EventNotifier. Simplify the code by using it, and also use the
> memory API consistently to set up and tear down the ioeventfds.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Avi Kivity <avi@redhat.com>
>
> qemu-system-x86_64: /home/cam/src/git/qemu/memory.c:1244: memory_region_del_even
> tfd: Assertion `i != mr->ioeventfd_nb' failed. This assertion failure
> occurs when the eventfd is triggered.
>
> I'll continue to dig around, but can you explain what this assertion
> is catching. Is there an initialization that might be missing?
Possibly a double-release of the eventfd. The assertion checks if the
parameters provided on del_eventfd match an existing one. Or that
matching is broken.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2012-08-22 8:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 4:29 [Qemu-devel] ivshmem assertion failure with EventNotifier Cam Macdonell
2012-08-22 8:05 ` Jan Kiszka [this message]
2012-08-22 12:01 ` Paolo Bonzini
2012-08-22 17:00 ` Cam Macdonell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503492C4.6080207@web.de \
--to=jan.kiszka@web.de \
--cc=avi@redhat.com \
--cc=cam@cs.ualberta.ca \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.