All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Stefan Fröberg" <stefan.froberg@petroprogram.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] valgrind: valgrind/valgrind.h missing if --disable-tls enabled
Date: Wed, 22 Aug 2012 11:58:17 +0300	[thread overview]
Message-ID: <50349F29.5000809@petroprogram.com> (raw)
In-Reply-To: <50340AD0.501@mind.be>

Good morning Arnout

22.8.2012 1:25, Arnout Vandecappelle kirjoitti:
> On 08/12/12 21:56, Stefan Froberg wrote:
>> +ifeq ($(BR2_GCC_ENABLE_TLS),y)
>> +    VALGRIND_CONF_OPT = --enable-tls
>> +else
>> +    VALGRIND_CONF_OPT = --disable-tls
>> +endif
>
>  This will only work for buildroot toolchains, not for crosstool-NG or
> external
> toolchains...
>
>

Hmmm...
How about this then?

ifeq ($(BR2_TOOLCHAIN_BUILDROOT),y) && ($(BR2_GCC_ENABLE_TLS),y)
        VALGRIND_CONF_OPT = --enable-tls
else
        VALGRIND_CONF_OPT = --disable-tls
endif

Enabling only tls if using buildroot toolchain and tls selected in gcc
and otherwise disabled.

Stefan

>
>  Regards,
>  Arnout
>

      reply	other threads:[~2012-08-22  8:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-12 19:56 [Buildroot] [PATCH] valgrind: valgrind/valgrind.h missing if --disable-tls enabled Stefan Froberg
2012-08-12 19:56 ` Stefan Froberg
2012-08-21 22:25   ` Arnout Vandecappelle
2012-08-22  8:58     ` Stefan Fröberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50349F29.5000809@petroprogram.com \
    --to=stefan.froberg@petroprogram.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.