From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Slaby Subject: Re: [PATCH] tty: move the async flags from the serial code into the tty includes Date: Wed, 22 Aug 2012 14:19:49 +0200 Message-ID: <5034CE65.7040607@suse.cz> References: <20120821133455.9090.24759.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bk0-f46.google.com ([209.85.214.46]:47817 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755856Ab2HVMTz (ORCPT ); Wed, 22 Aug 2012 08:19:55 -0400 In-Reply-To: <20120821133455.9090.24759.stgit@localhost.localdomain> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Alan Cox Cc: shijie8@gmail.com, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org On 08/21/2012 03:35 PM, Alan Cox wrote: > From: Alan Cox > > These are used with the tty_port flags which are tty generic so move the > flags into a more sensible place. This then makes it possible to add > helpers such as those suggested by Huang Shijie. Yes, the idea looks good to me. I was actually thinking of the same. But there are two issues with this patch (see below). > --- a/include/linux/serial.h > +++ b/include/linux/serial.h > @@ -15,6 +15,8 @@ > #ifdef __KERNEL__ > #include > > +#include > + There are no minus lines in serial.h -- we have two copies of the flags now? That looks insane. The flags are a user API. You concealed them by the #include inside the __KERNEL__ section (if I consider we do not have the flags defined twice). And if we move the include outside of the __KERNEL__ section, we shall update Kconfig, so that the new header is installed. > /* > * Counters of the input lines (CTS, DSR, RI, CD) interrupts > */ > diff --git a/include/linux/tty.h b/include/linux/tty.h > index 69a787f..dbebd1e 100644 > --- a/include/linux/tty.h > +++ b/include/linux/tty.h > @@ -43,6 +43,7 @@ > #include > #include > #include > +#include thanks, -- js suse labs