Re: [Qemu-devel] For 1.2: Re: [PATCH 3/8] migration: move total_time from ram stats to migration info

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1193 bytes --]

On 08/22/2012 07:22 AM, Anthony Liguori wrote:

Just restating things to make sure I'm clear...

>>>  { 'type': 'MigrationInfo',
>>>    'data': {'*status': 'str', '*ram': 'MigrationStats',
>>>             '*disk': 'MigrationStats',
>>> -           '*xbzrle-cache': 'XBZRLECacheStats'} }
>>> +           '*xbzrle-cache': 'XBZRLECacheStats',
>>> +           'total-time': 'int'} }
>>
>> Anthony - are you planning on taking this series for 1.2?
> 
> No.  This is a new feature and we're past freeze.

No, the overall series (patches 1,2,4-8) is not appropriate at this time.

> 
>> If we don't
>> get this patch in on time, then taking this for 1.3 would result in
>> changing released QMP interface (right now, there has been no release
>> with the field in the wrong type).
> 
> Ack.  We need to preserve compat with the 1.2 interface.

Yes, this particular patch 3 is a bug fix in order to prevent a future
regression when 1.3 takes the rest of the series, and must therefore be
part of the 1.2 release (and Luiz is on top of that, via the qmp branch).

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]