From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1T4CvG-0000k4-Co for mharc-qemu-trivial@gnu.org; Wed, 22 Aug 2012 11:32:46 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45344) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4Cv7-0000LA-Rl for qemu-trivial@nongnu.org; Wed, 22 Aug 2012 11:32:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4Cv0-0005b7-6C for qemu-trivial@nongnu.org; Wed, 22 Aug 2012 11:32:37 -0400 Received: from david.siemens.de ([192.35.17.14]:33252) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4Cus-0005ZW-Oj; Wed, 22 Aug 2012 11:32:22 -0400 Received: from mail1.siemens.de (localhost [127.0.0.1]) by david.siemens.de (8.13.6/8.13.6) with ESMTP id q7MFWDeb005970; Wed, 22 Aug 2012 17:32:14 +0200 Received: from mchn199C.mchp.siemens.de ([139.25.109.49]) by mail1.siemens.de (8.13.6/8.13.6) with ESMTP id q7MFWDYf000512; Wed, 22 Aug 2012 17:32:13 +0200 Message-ID: <5034FB7D.5050009@siemens.com> Date: Wed, 22 Aug 2012 17:32:13 +0200 From: Jan Kiszka User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: BALATON Zoltan References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Received-From: 192.35.17.14 Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Subject: Re: [Qemu-trivial] [PATCH v2] console: Correct computation of bytes per pixel from bits per pixel X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2012 15:32:45 -0000 On 2012-08-22 17:19, BALATON Zoltan wrote: > Division with round up is the correct way to compute this even if the > only case where division with round down gives incorrect result is > probably 15 bpp. This case was explicitely patched up in one of these > functions but was unhandled in the other. (I'm not sure about setting > 16 bpp for the 15bpp case either but I left that there for now.) > > Signed-off-by: BALATON Zoltan > --- > console.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > v2: Use DIV_ROUND_UP and extended commit message > > diff --git a/console.c b/console.c > index 4525cc7..9df1701 100644 > --- a/console.c > +++ b/console.c > @@ -1612,7 +1612,7 @@ PixelFormat > qemu_different_endianness_pixelformat(int bpp) > memset(&pf, 0x00, sizeof(PixelFormat)); > > pf.bits_per_pixel = bpp; > - pf.bytes_per_pixel = bpp / 8; > + pf.bytes_per_pixel = DIV_ROUND_UP(bpp, 8); > pf.depth = bpp == 32 ? 24 : bpp; > > switch (bpp) { > @@ -1661,13 +1661,12 @@ PixelFormat qemu_default_pixelformat(int bpp) > memset(&pf, 0x00, sizeof(PixelFormat)); > > pf.bits_per_pixel = bpp; > - pf.bytes_per_pixel = bpp / 8; > + pf.bytes_per_pixel = DIV_ROUND_UP(bpp, 8); > pf.depth = bpp == 32 ? 24 : bpp; > > switch (bpp) { > case 15: > pf.bits_per_pixel = 16; > - pf.bytes_per_pixel = 2; Removed unintentionally? Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45321) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4Cuz-0008Tb-Af for qemu-devel@nongnu.org; Wed, 22 Aug 2012 11:32:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4Cut-0005Zm-3E for qemu-devel@nongnu.org; Wed, 22 Aug 2012 11:32:29 -0400 Message-ID: <5034FB7D.5050009@siemens.com> Date: Wed, 22 Aug 2012 17:32:13 +0200 From: Jan Kiszka MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] console: Correct computation of bytes per pixel from bits per pixel List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: BALATON Zoltan Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org On 2012-08-22 17:19, BALATON Zoltan wrote: > Division with round up is the correct way to compute this even if the > only case where division with round down gives incorrect result is > probably 15 bpp. This case was explicitely patched up in one of these > functions but was unhandled in the other. (I'm not sure about setting > 16 bpp for the 15bpp case either but I left that there for now.) > > Signed-off-by: BALATON Zoltan > --- > console.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > v2: Use DIV_ROUND_UP and extended commit message > > diff --git a/console.c b/console.c > index 4525cc7..9df1701 100644 > --- a/console.c > +++ b/console.c > @@ -1612,7 +1612,7 @@ PixelFormat > qemu_different_endianness_pixelformat(int bpp) > memset(&pf, 0x00, sizeof(PixelFormat)); > > pf.bits_per_pixel = bpp; > - pf.bytes_per_pixel = bpp / 8; > + pf.bytes_per_pixel = DIV_ROUND_UP(bpp, 8); > pf.depth = bpp == 32 ? 24 : bpp; > > switch (bpp) { > @@ -1661,13 +1661,12 @@ PixelFormat qemu_default_pixelformat(int bpp) > memset(&pf, 0x00, sizeof(PixelFormat)); > > pf.bits_per_pixel = bpp; > - pf.bytes_per_pixel = bpp / 8; > + pf.bytes_per_pixel = DIV_ROUND_UP(bpp, 8); > pf.depth = bpp == 32 ? 24 : bpp; > > switch (bpp) { > case 15: > pf.bits_per_pixel = 16; > - pf.bytes_per_pixel = 2; Removed unintentionally? Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux