Re: [Qemu-devel] [PATCH] qapi: add 'query-target' command to return target arch/bit size (v2)

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 982 bytes --]

On 08/22/2012 09:09 AM, Anthony Liguori wrote:
> From: "Daniel P. Berrange" <berrange@redhat.com>
> 
> Add a 'query-target' QAPI command to allow management applications
> to determine what target architecture a QEMU binary is emulating
> without having to parse the binary name or -help output
> 
>   $ qmp-shell -p /tmp/qemu
>   (QEMU) query-target
>   {   u'return': {   u'arch': u'x86_64' }}
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> ---

> +
> +##
> +# @TargetInfo:
> +#
> +# Information describing the QEMU target.
> +#
> +# @arch: the target architecture (eg "x86_64", "i386", etc)

Missed my v1 comment that 'eg' is misspelled (would be 'e.g.'), and with
my recommendation for an alternate wording:

@arch: the target architecture (such as "x86_64" or "i686")

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]