From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4DVi-00074j-Nh for qemu-devel@nongnu.org; Wed, 22 Aug 2012 12:10:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4DVZ-0000lt-87 for qemu-devel@nongnu.org; Wed, 22 Aug 2012 12:10:26 -0400 Received: from david.siemens.de ([192.35.17.14]:32612) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4DVY-0000hy-Tn for qemu-devel@nongnu.org; Wed, 22 Aug 2012 12:10:17 -0400 Message-ID: <50350466.6080105@siemens.com> Date: Wed, 22 Aug 2012 18:10:14 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <5034F54F.30302@redhat.com> <5034F7AA.7030105@siemens.com> <503501B3.6060108@redhat.com> In-Reply-To: <503501B3.6060108@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Bug in option parsing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Martin Kletzander Cc: Jason Baron , "qemu-devel@nongnu.org" On 2012-08-22 17:58, Martin Kletzander wrote: > On 08/22/2012 05:15 PM, Jan Kiszka wrote: >> On 2012-08-22 17:05, Martin Kletzander wrote: >>> Hi everybody, >>> >>> while coding the support for Jason's dump-guest-core option I realized >>> there is (probably) a problem with the way QEMU parses additional >>> machine options ('dump-guest-core', 'kvm_shadow_mem' etc.). Running QEMU >>> with option to -machine works ok, but using '-M' (as libvirt does) works >>> only w/o additional options, otherwise it ends in an error (the whole >>> string is probably parsed as a machine name). >>> >>> Is '-M' so obsolete it shouldn't be used at all or is it just an bug? We >>> still use '-M' everywhere I know and '-machine' isn't compatible with >>> older versions and different builds of QEMU. >>> >>> Should I file a bug or do we have to drop '-M' for this situations? >> >> If libvirt uses -M just like -machine, i.e. with more than a machine >> name, that would be a libvirt bug (but that would have been noticed much >> earlier - did you patch something?). QEMU only keeps -M >> around to please existing users that didn't switch yet. It is NOT an >> alias for -machine. >> > > There is no option *yet* that libvirt would like to use as an additional > option for machine type, but I'm working on the first one and I've hit this. > > So your suggestion would be to use -machine wherever it's possible and > fallback to -M only when -machine is not supported? Yep. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux