From: Alex Elder <elder@inktank.com>
To: xfs@oss.sgi.com
Subject: Re: xfstests: Replace lstat64 with cat in test 120
Date: Wed, 22 Aug 2012 15:59:08 -0500 [thread overview]
Message-ID: <5035481C.5050503@inktank.com> (raw)
In-Reply-To: <20120822185456.4F189B010E6D@gulag1.americas.sgi.com>
On 08/22/2012 01:54 PM, Rich Johnston wrote:
> The later versions of libtool (i.e.2.4+) create a wrapper (bash script) for
> lstat64 in the src directory. The wrapper calls the real binary created by
> libtool (.libs/lstat64)
>
> Test 120 only copies src/lstat64 to $SCRATCH_MNT. If a later version of
> libtool is used then only the wrapper is copied to $SCRATCH_MNT and the wrapper
> will fail to find .libs/lstat64.
>
> ~/xfstests # diff 120.out 120.out.bad
> /mnt/scratch/lstat64: error: `/mnt/scratch/.libs/lstat64' does not exist
> This script is just a wrapper for lstat64.
> See the libtool documentation for more information.
>
> This patch copies /usr/bin/cat (which is readily availible on unix systems) to
> $SCRATCH_MNT instead of src/lstat64.
I was going to suggest you use /bin/cat instead, but it appears
the actual patch does.
Please update your description. Otherwise, looks good to me.
Reviewed-by: Alex Elder <elder@inktank.com>
>
> Signed-off-by: Rich Johnston <rjohnston@sgi.com>
>
> ---
> 120 | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> Index: b/120
> ===================================================================
> --- a/120
> +++ b/120
> @@ -68,12 +68,12 @@ fi
>
> #executable file
> echo "*** copying file ***"
> -cp src/lstat64 $SCRATCH_MNT
> -src/lstat64 $SCRATCH_MNT/lstat64 >$tmp.out
> +cp /bin/cat $SCRATCH_MNT
> +src/lstat64 $SCRATCH_MNT/cat >$tmp.out
> sleep 5
> echo "*** executing file ***"
> -$SCRATCH_MNT/lstat64 $SCRATCH_MNT/lstat64 >/dev/null
> -_compare_access_times $SCRATCH_MNT/lstat64 "executing file"
> +$SCRATCH_MNT/cat $SCRATCH_MNT/cat >/dev/null
> +_compare_access_times $SCRATCH_MNT/cat "executing file"
>
> #reading file
> echo "*** creating file ***"
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-08-22 20:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 18:54 xfstests: Replace lstat64 with cat in test 120 Rich Johnston
2012-08-22 20:59 ` Alex Elder [this message]
2012-08-23 16:12 ` Rich Johnston
[not found] <20120822190605.279843301@sgi.com>
2012-08-22 19:06 ` rjohnston
2012-08-22 19:06 ` rjohnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5035481C.5050503@inktank.com \
--to=elder@inktank.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.