Re: [PATCH] sms: Add delay before submitting multiple SMS to modem

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1362 bytes --]

Hi Guillaume,

On 08/22/2012 04:29 AM, Guillaume Zajac wrote:
> For 3GPP GSM test case 34.2.9.1 and 34.2.9.1 and WCDMA test
> case 16.1.9.1 and 16.1.9.2, we need to transmitmultiple SMS
> using same RRC channel.
> oFono needs to wait its tx queue to be filled in with the
> next SMS before submitting the first one to use +CMMS=1 modem
> option.
> ---
>   src/sms.c |    4 +++-
>   1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/src/sms.c b/src/sms.c
> index acfc39b..443e502 100644
> --- a/src/sms.c
> +++ b/src/sms.c
> @@ -50,6 +50,8 @@
>   #define TXQ_MAX_RETRIES 4
>   #define NETWORK_TIMEOUT 332
>
> +#define SMS_TX_NEXT 500
> +
>   static gboolean tx_next(gpointer user_data);
>
>   static GSList *g_drivers = NULL;
> @@ -2072,7 +2074,7 @@ int __ofono_sms_txq_submit(struct ofono_sms *sms, GSList *list,
>   	g_queue_push_tail(sms->txq, entry);
>
>   	if (sms->registered&&  g_queue_get_length(sms->txq) == 1)
> -		sms->tx_source = g_timeout_add(0, tx_next, sms);
> +		sms->tx_source = g_timeout_add(SMS_TX_NEXT, tx_next, sms);
>

Umm, I don't even know how to respond to this.  Lets just say that this 
isn't going to be accepted upstream ;)  Why don't you use multi-segment 
SMS, or queue the messages offline.

>   	if (uuid)
>   		memcpy(uuid,&entry->uuid, sizeof(*uuid));

Regards,
-Denis