From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Heiny Subject: Re: [RFC PATCH 1/17] input: RMI4 public header file and documentation. Date: Wed, 22 Aug 2012 17:26:52 -0700 Message-ID: <503578CC.801@synaptics.com> References: <1345241877-16200-1-git-send-email-cheiny@synaptics.com> <1345241877-16200-2-git-send-email-cheiny@synaptics.com> <1965688.fPKEQJnVvJ@dtor-d630.eng.vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from us-mx3.synaptics.com ([12.239.217.85]:15747 "EHLO us-mx3.synaptics.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757736Ab2HWA0y (ORCPT ); Wed, 22 Aug 2012 20:26:54 -0400 In-Reply-To: <1965688.fPKEQJnVvJ@dtor-d630.eng.vmware.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: Linus Walleij , "Rafael J. Wysocki" , Jean Delvare , Linux Kernel , Linux Input , Allie Xiong , William Manson , Peichen Chang , Joerie de Gram , Wolfram Sang , Mathieu Poirier , Linus Walleij , Naveen Kumar Gaddipati , Henrik Rydberg On 08/22/2012 02:45 PM, Dmitry Torokhov wrote: > On Wednesday, August 22, 2012 09:08:00 PM Linus Walleij wrote: >> >On Sat, Aug 18, 2012 at 12:17 AM, Christopher Heiny >> > wrote: >> > >>> > >+/* Helper fn to convert a byte array representing a short in the RMI >>> > >+ * endian-ness to a short in the native processor's specific endianness. > Is RMI-endiannes different from BE and LE (joking)? Please simply state what > on-wire endianness is and use xx_to_cpu() or cpu_to_xx() as needed. I think I > mentioned it about a year ago already... Gronk. I thought I'd killed that. But obviously didn't do a thorough job. [Slinks off in embarrassment.]