From: Saul Wold <sgw@linux.intel.com>
To: Tom Rini <trini@ti.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v2 1/5] u-boot-mkimage: Correct EXTRA_OEMAKE
Date: Wed, 22 Aug 2012 20:27:14 -0700 [thread overview]
Message-ID: <5035A312.9000903@linux.intel.com> (raw)
In-Reply-To: <1345592379-8704-1-git-send-email-trini@ti.com>
On 08/21/2012 04:39 PM, Tom Rini wrote:
> - HOSTLD has never been used in U-Boot, drop.
> - HOSTSTRIP has been valid for a long time for tools
> - Same for HOSTCFLAGS / HOSTLDFLAGS
>
> Signed-off-by: Tom Rini <trini@ti.com>
> ---
> meta/recipes-bsp/u-boot/u-boot-mkimage_2011.03.bb | 4 ++--
> meta/recipes-bsp/u-boot/u-boot-mkimage_2011.06.bb | 4 ++--
> .../u-boot/u-boot-mkimage_2012.04.01.bb | 4 +++-
> 3 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/meta/recipes-bsp/u-boot/u-boot-mkimage_2011.03.bb b/meta/recipes-bsp/u-boot/u-boot-mkimage_2011.03.bb
> index 34bae8e..fdbe7c9 100644
> --- a/meta/recipes-bsp/u-boot/u-boot-mkimage_2011.03.bb
> +++ b/meta/recipes-bsp/u-boot/u-boot-mkimage_2011.03.bb
> @@ -4,7 +4,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=1707d6db1d42237583f50183a5651ecb \
> file://README;beginline=1;endline=22;md5=3a00ef51d3fc96e9d6c1bc4708ccd3b5"
> SECTION = "bootloader"
>
> -PR = "r1"
> +PR = "r2"
>
> SRC_URI = "ftp://ftp.denx.de/pub/u-boot/u-boot-${PV}.tar.bz2 \
> file://0001-Drop-config.h-include-in-tools-imximage.h.patch \
> @@ -17,7 +17,7 @@ S = "${WORKDIR}/u-boot-${PV}"
>
> BBCLASSEXTEND = "native nativesdk"
>
> -EXTRA_OEMAKE = 'HOSTCC="${CC}" HOSTLD="${LD}" HOSTSTRIP=true'
> +EXTRA_OEMAKE = 'HOSTCC="${CC}" HOSTCFLAGS="${CFLAGS}" HOSTLDFLAGS="${LDFLAGS}" HOSTSTRIP=true'
>
I know you fixed the quote, but did you do any kind of test build?
Please see the Autobuilder:
http://autobuilder.yoctoproject.org:8010/builders/nightly-world/builds/243/steps/shell_34/logs/stdio
for additional failures, please let me know what testing you do when you
submit the next patch set please.
Thanks
Sau!
> do_compile () {
> oe_runmake tools
> diff --git a/meta/recipes-bsp/u-boot/u-boot-mkimage_2011.06.bb b/meta/recipes-bsp/u-boot/u-boot-mkimage_2011.06.bb
> index 3ca0c2c..c4921d6 100644
> --- a/meta/recipes-bsp/u-boot/u-boot-mkimage_2011.06.bb
> +++ b/meta/recipes-bsp/u-boot/u-boot-mkimage_2011.06.bb
> @@ -4,7 +4,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=1707d6db1d42237583f50183a5651ecb \
> file://README;beginline=1;endline=22;md5=5ba4218ac89af7846802d0348df3fb90"
> SECTION = "bootloader"
>
> -PR = "r0"
> +PR = "r1"
>
> SRC_URI = "ftp://ftp.denx.de/pub/u-boot/u-boot-${PV}.tar.bz2"
>
> @@ -15,7 +15,7 @@ S = "${WORKDIR}/u-boot-${PV}"
>
> BBCLASSEXTEND = "native nativesdk"
>
> -EXTRA_OEMAKE = 'HOSTCC="${CC}" HOSTLD="${LD}" HOSTLDFLAGS="${LDFLAGS}" HOSTSTRIP=true'
> +EXTRA_OEMAKE = 'HOSTCC="${CC}" HOSTCFLAGS="${CFLAGS}" HOSTLDFLAGS="${LDFLAGS}" HOSTSTRIP=true'
>
> do_compile () {
> oe_runmake tools
> diff --git a/meta/recipes-bsp/u-boot/u-boot-mkimage_2012.04.01.bb b/meta/recipes-bsp/u-boot/u-boot-mkimage_2012.04.01.bb
> index aa107fe..c41a2f1 100644
> --- a/meta/recipes-bsp/u-boot/u-boot-mkimage_2012.04.01.bb
> +++ b/meta/recipes-bsp/u-boot/u-boot-mkimage_2012.04.01.bb
> @@ -3,6 +3,8 @@ LICENSE = "GPLv2+"
> LIC_FILES_CHKSUM = "file://COPYING;md5=1707d6db1d42237583f50183a5651ecb"
> SECTION = "bootloader"
>
> +PR = "r1"
> +
> # This is needs to be validated among supported BSP's before we can
> # make it default
> DEFAULT_PREFERENCE = "-1"
> @@ -18,7 +20,7 @@ SRC_URI = "git://git.denx.de/u-boot.git;branch=master;protocol=git"
>
> S = "${WORKDIR}/git"
>
> -EXTRA_OEMAKE = 'HOSTCC="${CC}" HOSTLD="${LD}" HOSTLDFLAGS="${LDFLAGS}" HOSTSTRIP=true'
> +EXTRA_OEMAKE = 'HOSTCC="${CC}" HOSTCFLAGS="${CFLAGS}" HOSTLDFLAGS="${LDFLAGS}" HOSTSTRIP=true'
>
> do_compile () {
> oe_runmake tools
>
prev parent reply other threads:[~2012-08-23 3:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 23:39 [PATCH v2 1/5] u-boot-mkimage: Correct EXTRA_OEMAKE Tom Rini
2012-08-21 23:39 ` [PATCH v2 2/5] u-boot-fw-utils: " Tom Rini
2012-08-21 23:39 ` [PATCH v2 3/5] u-boot-fw-utils: Update to v2012.07 Tom Rini
2012-08-21 23:39 ` [PATCH v2 4/5] u-boot-mkimage: " Tom Rini
2012-08-21 23:39 ` [PATCH v2 5/5] u-boot: " Tom Rini
2012-08-23 3:27 ` Saul Wold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5035A312.9000903@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=trini@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.