Re: [Qemu-devel] [PATCH 3/6] QAPI: Introduce memchar_write QMP command

[Lei Li <lilei@linux.vnet.ibm.com>]

On 08/23/2012 01:42 PM, Eric Blake wrote:
> On 08/22/2012 11:14 PM, Lei Li wrote:
>> Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
> Subject line uses '_', but the QMP command uses '-' [1]
>
>> ---
>>   hmp-commands.hx  |   16 ++++++++++++++++
>>   hmp.c            |   15 +++++++++++++++
>>   hmp.h            |    1 +
>>   qapi-schema.json |   28 ++++++++++++++++++++++++++++
>>   qemu-char.c      |   36 ++++++++++++++++++++++++++++++++++++
>>   qmp-commands.hx  |   33 +++++++++++++++++++++++++++++++++
>>   6 files changed, 129 insertions(+), 0 deletions(-)
>>
>> diff --git a/hmp-commands.hx b/hmp-commands.hx
>> index f6104b0..829aea1 100644
>> --- a/hmp-commands.hx
>> +++ b/hmp-commands.hx
>> @@ -797,6 +797,22 @@ Inject an NMI on the given CPU (x86 only).
>>   ETEXI
>>   
>>       {
>> +        .name       = "memchar-write",
> HMP commands should use '_', not '-'.
>
>> +++ b/qapi-schema.json
>> @@ -235,6 +235,34 @@
>>   ##
>>   { 'command': 'query-chardev', 'returns': ['ChardevInfo'] }
>>   
>> +{ 'enum': 'DataFormat'
>> +  'data': [ 'utf8', 'base64' ] }
> Missing documentation for DataFormat (see for example how @ErrorClass is
> documented).
>
Sure, I will look into it and add documentation in v3, thanks!



-- 
Lei